Use full height on attribute form with drag and drop layout

And fix some file permission issues
qgis · Jun 5, 2015 · e66dd99 · e66dd99
1 parent 316210d
commit e66dd99
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/python/gui/qgscolorswatchgrid.sip b/python/gui/qgscolorswatchgrid.sip
diff --git a/python/gui/qgscolorwidgets.sip b/python/gui/qgscolorwidgets.sip
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -387,15 +387,16 @@ void QgsAttributeForm::init()
   // Tab layout
   if ( !formWidget && mLayer->editorLayout() == QgsVectorLayer::TabLayout )
   {
-    QTabWidget* tabWidget = new QTabWidget( this );
+    QTabWidget* tabWidget = new QTabWidget();
     layout()->addWidget( tabWidget );
 
     Q_FOREACH ( QgsAttributeEditorElement *widgDef, mLayer->attributeEditorElements() )
     {
       QWidget* tabPage = new QWidget( tabWidget );
 
       tabWidget->addTab( tabPage, widgDef->name() );
-      QGridLayout *tabPageLayout = new QGridLayout( tabPage );
+      QGridLayout* tabPageLayout = new QGridLayout();
+      tabPage->setLayout( tabPageLayout );
 
       if ( widgDef->type() == QgsAttributeEditorElement::AeTypeContainer )
       {
@@ -645,7 +646,7 @@ QWidget* QgsAttributeForm::createWidgetFromDef( const QgsAttributeEditorElement
         newWidget = scrollArea;
       }
 
-      QGridLayout* gbLayout = new QGridLayout( myContainer );
+      QGridLayout* gbLayout = new QGridLayout();
       myContainer->setLayout( gbLayout );
 
       int index = 0;
@@ -680,7 +681,9 @@ QWidget* QgsAttributeForm::createWidgetFromDef( const QgsAttributeEditorElement
 
         ++index;
       }
-      gbLayout->addItem( new QSpacerItem( 0, 0, QSizePolicy::Minimum, QSizePolicy::Expanding ), index, 0 );
+      QWidget* spacer = new QWidget();
+      spacer->setSizePolicy( QSizePolicy::Expanding, QSizePolicy::Preferred );
+      gbLayout->addWidget( spacer, index, 0 );
 
       labelText = QString::null;
       labelOnTop = true;