You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@borysiasty looks like this causes crashes / segfaults (at least) in unit tests. Can we revert this and work out in a pull request what's causing trouble here?
@m-kuhn it's not this commit - it's from one of my processing ones. I need to make sure the providers are all correctly deregistered when the test suite finishes. Will do asap
6 commit comments
m-kuhn commentedon Apr 6, 2017
@borysiasty looks like this causes crashes / segfaults (at least) in unit tests. Can we revert this and work out in a pull request what's causing trouble here?
nyalldawson commentedon Apr 6, 2017
@m-kuhn it's not this commit - it's from one of my processing ones. I need to make sure the providers are all correctly deregistered when the test suite finishes. Will do asap
m-kuhn commentedon Apr 6, 2017
Thanks, @nyalldawson
borysiasty commentedon Apr 6, 2017
Thanks @nyalldawson. @m-kuhn I didn't make a PR, as it's just one if-else statement added (all the rest is just indentation change)
arnaud-morvan commentedon Apr 6, 2017
@borysiasty : Note that it was not necessary to indent the for loop if the layer is empty, to avoid conflicts.
borysiasty commentedon Jul 11, 2017
Right, sorry for the unnecessary buzz.