Hide deprecated datum transforms by default

nyalldawson · nyalldawson · commit e58cccb2a2e5 · 2019-03-19T13:32:13.000+10:00
Instead of showing by default and requiring users to manually
hide them, reverse this logic and hide deprecated ones by default
and require motivated users to manually opt in to showing them.

Result: less likely for users to accidentally use deprecated
transforms.

Sponsored by ICSM
diff --git a/src/gui/qgsdatumtransformdialog.cpp b/src/gui/qgsdatumtransformdialog.cpp
@@ -59,7 +59,7 @@ QgsDatumTransformDialog::QgsDatumTransformDialog( const QgsCoordinateReferenceSy
 
   QgsSettings settings;
   restoreGeometry( settings.value( QStringLiteral( "Windows/DatumTransformDialog/geometry" ) ).toByteArray() );
-  mHideDeprecatedCheckBox->setChecked( settings.value( QStringLiteral( "Windows/DatumTransformDialog/hideDeprecated" ), false ).toBool() );
+  mHideDeprecatedCheckBox->setChecked( settings.value( QStringLiteral( "Windows/DatumTransformDialog/hideDeprecated" ), true ).toBool() );
 
   mLabelSrcDescription->clear();
   mLabelDstDescription->clear();
diff --git a/src/ui/qgsdatumtransformdialogbase.ui b/src/ui/qgsdatumtransformdialogbase.ui
@@ -32,7 +32,7 @@
      <item>
       <widget class="QCheckBox" name="mHideDeprecatedCheckBox">
        <property name="text">
-        <string>Hide deprecated</string>
+        <string>Hide deprecated transformations</string>
        </property>
       </widget>
      </item>
