Q_FOREACH use to iterate over joins info

pblottiere · pblottiere · commit e52414ea9dfd · 2017-07-02T17:21:36.000+02:00
diff --git a/src/core/qgsvectorlayerjoinbuffer.cpp b/src/core/qgsvectorlayerjoinbuffer.cpp
@@ -398,15 +398,13 @@ QList<const QgsVectorLayerJoinInfo *> QgsVectorLayerJoinBuffer::joinsWhereFieldI
 {
   QList<const QgsVectorLayerJoinInfo *> infos;
 
-  for ( int i = 0; i < mVectorJoins.count(); i++ )
+  Q_FOREACH ( const QgsVectorLayerJoinInfo &info, mVectorJoins )
   {
-    const QgsVectorLayerJoinInfo *info = &( mVectorJoins[i] );
-
-    if ( infos.contains( info ) )
+    if ( infos.contains( &info ) )
       continue;
 
-    if ( info->targetFieldName() == field.name() )
-      infos.append( info );
+    if ( info.targetFieldName() == field.name() )
+      infos.append( &info );
   }
 
   return infos;

Original file line number	Diff line number	Diff line change
`@@ -398,15 +398,13 @@ QList<const QgsVectorLayerJoinInfo *> QgsVectorLayerJoinBuffer::joinsWhereFieldI`
`398`	`398`	`{`
`399`	`399`	`QList<const QgsVectorLayerJoinInfo *> infos;`
`400`	`400`
`401`		`- for ( int i = 0; i < mVectorJoins.count(); i++ )`
	`401`	`+ Q_FOREACH ( const QgsVectorLayerJoinInfo &info, mVectorJoins )`
`402`	`402`	`{`
`403`		`- const QgsVectorLayerJoinInfo *info = &( mVectorJoins[i] );`
`404`		`-`
`405`		`- if ( infos.contains( info ) )`
	`403`	`+ if ( infos.contains( &info ) )`
`406`	`404`	`continue;`
`407`	`405`
`408`		`- if ( info->targetFieldName() == field.name() )`
`409`		`- infos.append( info );`
	`406`	`+ if ( info.targetFieldName() == field.name() )`
	`407`	`+ infos.append( &info );`
`410`	`408`	`}`
`411`	`409`
`412`	`410`	`return infos;`