Skip to content

Commit e503c70

Browse files
committedFeb 21, 2016
change QgsAbstractGeometryV2::coordinateSequence() to return a
implicitly shared copy of an internal cache instead of recreating the coordinate sequence again and again. Improves performance of the nodetool on large features a lot (refs #13963) Also introduce Qgs(Coordinate|Ring|Point)SequenceV2 typedefs.
1 parent 4485d3a commit e503c70

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+365
-346
lines changed
 

‎python/core/geometry/qgsabstractgeometryv2.sip

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,9 @@ class QgsAbstractGeometryV2
221221
virtual bool nextVertex( QgsVertexId& id, QgsPointV2& vertex ) const = 0;
222222

223223
/** Retrieves the sequence of geometries, rings and nodes.
224-
* @param coord destination for coordinate sequence.
224+
* @return coordinate sequence
225225
*/
226-
virtual void coordinateSequence( QList< QList< QList< QgsPointV2 > > >& coord /Out/ ) const = 0;
226+
virtual QList< QList< QList< QgsPointV2 > > > coordinateSequence() const = 0;
227227

228228
/** Returns the number of nodes contained in the geometry
229229
*/

‎python/core/geometry/qgscircularstringv2.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class QgsCircularStringV2: public QgsCurveV2
8282
/**
8383
* @copydoc QgsCurveV2::pointAt()
8484
*/
85-
bool pointAt( int i, QgsPointV2& vertex, QgsVertexId::VertexType& type ) const;
85+
bool pointAt( int node, QgsPointV2& point, QgsVertexId::VertexType& type ) const;
8686

8787
/**
8888
* @copydoc QgsCurveV2::sumUpArea()

0 commit comments

Comments
 (0)
Please sign in to comment.