Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Add checkbox to only load wfs features intersecting the current canva…
…s extent. Funded by Sourcepole QGIS Enterprise
- Loading branch information
Showing
3 changed files
with
97 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4e4839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never did a comment on a commit :-)
But @mhugent this commit breaks our use case of WFS's and in my opinion does not add something to the old implementation. See for example:
http://hub.qgis.org/issues/13117
and this thread
https://lists.osgeo.org/pipermail/qgis-developer/2015-October/040038.html
can we discuss about this one?
e4e4839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you really try a compile without that commit? The uncached mode (subsequently downloading features) was broken during multithreaded rendering. What this commit adds is a convenient way to load the features crossing the current view extent into memory (without writing the BBOX by hand). The checkbox was already there earlier an a lot of people wanted it back.
e4e4839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mhugent , thanks for your anwer, I thought you introduced this option.
Nope, sorry. Did not do that try to compile with that commit, but Multithreading was introduced when? Because 2.8.3 is still working as we expect/want.
Maybe have a chat about this during hackfest?
e4e4839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik in 2.4. And loading while zooming / panning also does not work for me when removing the few lines of this commit with current master. But if it works for you without this commit, I'll be happy to revert those lines.