Don't leak memory in bookmarks delegate

qgis · Dec 4, 2017 · e4dabe5 · e4dabe5
1 parent 57dc9de
commit e4dabe5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/app/qgsbookmarks.cpp b/src/app/qgsbookmarks.cpp
@@ -109,7 +109,7 @@ QgsBookmarks::QgsBookmarks( QWidget *parent )
   mProxyModel->setSourceModel( mModel );
 
   lstBookmarks->setModel( mProxyModel );
-  lstBookmarks->setItemDelegate( new QgsDoubleSpinBoxBookmarksDelegate );
+  lstBookmarks->setItemDelegate( new QgsDoubleSpinBoxBookmarksDelegate( this ) );
 
   connect( mModel, &QgsMergedBookmarksTableModel::layoutChanged, mProxyModel, &QgsBookmarksProxyModel::_resetModel );
 
@@ -760,6 +760,12 @@ QVariant QgsBookmarksProxyModel::headerData( int section, Qt::Orientation orient
   return sourceModel()->headerData( section, orientation, role );
 }
 
+QgsDoubleSpinBoxBookmarksDelegate::QgsDoubleSpinBoxBookmarksDelegate( QObject *parent )
+  : QStyledItemDelegate( parent )
+{
+
+}
+
 QString QgsDoubleSpinBoxBookmarksDelegate::displayText( const QVariant &value, const QLocale &locale ) const
 {
   if ( value.userType() == QVariant::Double )

diff --git a/src/app/qgsbookmarks.h b/src/app/qgsbookmarks.h
@@ -82,6 +82,8 @@ class QgsDoubleSpinBoxBookmarksDelegate : public QStyledItemDelegate
 
   public:
 
+    explicit QgsDoubleSpinBoxBookmarksDelegate( QObject *parent = nullptr );
+
     QString displayText( const QVariant &value, const QLocale &locale ) const override;
 
     QWidget *createEditor( QWidget *parent,