Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More types support for QgsVectorFileWriter
- Loading branch information
Showing
7 changed files
with
251 additions
and
103 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
e351d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn, could this possibly have caused the following regression: http://hub.qgis.org/issues/14158 ?
e351d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be the default for quite some time already:
https://github.com/qgis/QGIS/blame/master/src/core/qgsvectorfilewriter.cpp#L686
e351d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn , sorry if this I wrongly flagged this as causing regression. I'm very confident I was doing KML -> shapefile save as under QGIS 2.12 without having to play with a SHPT option.
e351d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn , I looked at QGIS 2.12; on that version, there are no layer options for ESRP Shapefile in the Save As dialogue:
It's slightly odd as it appears the options were added in this commit ( f78af8b ) which dates back to QGIS 2.8, yet those layer options are absent from 2.12.
Beyond that, there is still a need to fix Save As -> ESRP Shapefile so that, by default, the SHPT layer option is not set, to allow for .shp to be saved as it used to be the case prior to now. I've looked at the code a bit, but it's one of the many parts of QGIS that isn't familiar to me. If I add a "" value, and sets that as default, I get an error saying that SHPT doesn't recognize "" as a valid value.
e351d24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that the key specified in the insert does not match with the ogr driver name? f78af8b#diff-2572d1079b3ce82d94d0d5fef972b795R648