QgsMessageLogViewer: limit number of messages to avoid blowing RAM (f…

…ixes #44202)
qgis · Jul 21, 2021 · e2e7d52 · e2e7d52
1 parent b5d6610
commit e2e7d52
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/gui/qgsmessagelogviewer.cpp b/src/gui/qgsmessagelogviewer.cpp
@@ -109,6 +109,12 @@ void QgsMessageLogViewer::reject()
 
 void QgsMessageLogViewer::logMessage( const QString &message, const QString &tag, Qgis::MessageLevel level )
 {
+  constexpr int MESSAGE_COUNT_LIMIT = 10000;
+  // Avoid logging too many messages, which might blow memory.
+  if ( mMessageLoggedCount == MESSAGE_COUNT_LIMIT )
+    return;
+  ++mMessageLoggedCount;
+
   QString cleanedTag = tag;
   if ( cleanedTag.isNull() )
     cleanedTag = tr( "General" );
@@ -164,6 +170,9 @@ void QgsMessageLogViewer::logMessage( const QString &message, const QString &tag
   QString prefix = QStringLiteral( "<font color=\"%1\">%2 &nbsp;&nbsp;&nbsp; %3 &nbsp;&nbsp;&nbsp;</font>" )
                    .arg( color.name(), QDateTime::currentDateTime().toString( Qt::ISODate ), levelString );
   QString cleanedMessage = message;
+  if ( mMessageLoggedCount == MESSAGE_COUNT_LIMIT )
+    cleanedMessage = tr( "Message log truncated" );
+
   cleanedMessage = cleanedMessage.prepend( prefix ).replace( '\n', QLatin1String( "<br>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;" ) );
   w->appendHtml( cleanedMessage );
   w->verticalScrollBar()->setValue( w->verticalScrollBar()->maximum() );

diff --git a/src/gui/qgsmessagelogviewer.h b/src/gui/qgsmessagelogviewer.h
@@ -64,6 +64,7 @@ class GUI_EXPORT QgsMessageLogViewer: public QDialog, private Ui::QgsMessageLogV
 
     QString mClickedAnchor;
     QMenu *mTabBarContextMenu = nullptr;
+    int mMessageLoggedCount = 0;
 };
 
 #endif