Fix leak when writing features with null geometry to vector layers

nyalldawson · nyalldawson · commit e2dad8e33108 · 2018-03-15T17:53:49.000+11:00
(cherry-picked from eb4951)
diff --git a/src/core/qgsvectorfilewriter.cpp b/src/core/qgsvectorfilewriter.cpp
@@ -2223,7 +2223,7 @@ gdal::ogr_feature_unique_ptr QgsVectorFileWriter::createFeature( const QgsFeatur
     }
     else
     {
-      OGR_F_SetGeometry( poFeature.get(), createEmptyGeometry( mWkbType ) );
+      OGR_F_SetGeometryDirectly( poFeature.get(), createEmptyGeometry( mWkbType ) );
     }
   }
   return poFeature;

Original file line number	Diff line number	Diff line change
`@@ -2223,7 +2223,7 @@ gdal::ogr_feature_unique_ptr QgsVectorFileWriter::createFeature( const QgsFeatur`
`2223`	`2223`	`}`
`2224`	`2224`	`else`
`2225`	`2225`	`{`
`2226`		`- OGR_F_SetGeometry( poFeature.get(), createEmptyGeometry( mWkbType ) );`
	`2226`	`+ OGR_F_SetGeometryDirectly( poFeature.get(), createEmptyGeometry( mWkbType ) );`
`2227`	`2227`	`}`
`2228`	`2228`	`}`
`2229`	`2229`	`return poFeature;`