QgsGeometryCheck::LayerFeatureIds constructor: avoid false positive c…

…ppcheck about self assignment
qgis · Jun 15, 2020 · e292cb7 · e292cb7
1 parent c680caa
commit e292cb7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrycheck.h b/src/analysis/vector/geometry_checker/qgsgeometrycheck.h
@@ -140,7 +140,7 @@ class ANALYSIS_EXPORT QgsGeometryCheck
     struct ANALYSIS_EXPORT LayerFeatureIds
     {
       LayerFeatureIds() = default;
-      LayerFeatureIds( const QMap<QString, QgsFeatureIds> &ids ) SIP_SKIP;
+      LayerFeatureIds( const QMap<QString, QgsFeatureIds> &idsIn ) SIP_SKIP;
 
       QMap<QString, QgsFeatureIds> ids SIP_SKIP;
 

diff --git a/src/analysis/vector/geometry_checker/qgsgeometrycheckerror.cpp b/src/analysis/vector/geometry_checker/qgsgeometrycheckerror.cpp
@@ -215,7 +215,7 @@ void QgsGeometryCheckError::update( const QgsGeometryCheckError *other )
   mGeometry = other->mGeometry;
 }
 
-QgsGeometryCheck::LayerFeatureIds::LayerFeatureIds( const QMap<QString, QgsFeatureIds> &ids )
-  : ids( ids )
+QgsGeometryCheck::LayerFeatureIds::LayerFeatureIds( const QMap<QString, QgsFeatureIds> &idsIn )
+  : ids( idsIn )
 {
 }