Fix more loop issues

qgis · Aug 9, 2020 · e14600b · e14600b
1 parent f69510e
commit e14600b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/app/qgsmaptooladdcircle.cpp b/src/app/qgsmaptooladdcircle.cpp
@@ -97,7 +97,7 @@ void QgsMapToolAddCircle::deactivate()
 
   // keep z value from the first snapped point
   std::unique_ptr<QgsCircularString> lineString( mCircle.toCircularString() );
-  for ( const QgsPoint point : qgis::as_const( mPoints ) )
+  for ( const QgsPoint &point : qgis::as_const( mPoints ) )
   {
     if ( QgsWkbTypes::hasZ( point.wkbType() ) &&
          point.z() != defaultZValue() )

diff --git a/src/app/qgsmaptooladdellipse.cpp b/src/app/qgsmaptooladdellipse.cpp
@@ -97,7 +97,7 @@ void QgsMapToolAddEllipse::deactivate()
 
   // keep z value from the first snapped point
   std::unique_ptr<QgsLineString> ls( mEllipse.toLineString( segments() ) );
-  for ( const QgsPoint point : qgis::as_const( mPoints ) )
+  for ( const QgsPoint &point : qgis::as_const( mPoints ) )
   {
     if ( QgsWkbTypes::hasZ( point.wkbType() ) &&
          point.z() != defaultZValue() )

diff --git a/src/app/qgsmaptooladdregularpolygon.cpp b/src/app/qgsmaptooladdregularpolygon.cpp
@@ -115,7 +115,7 @@ void QgsMapToolAddRegularPolygon::deactivate()
 
   // keep z value from the first snapped point
   std::unique_ptr<QgsLineString> ls( mRegularPolygon.toLineString() );
-  for ( const QgsPoint point : qgis::as_const( mPoints ) )
+  for ( const QgsPoint &point : qgis::as_const( mPoints ) )
   {
     if ( QgsWkbTypes::hasZ( point.wkbType() ) &&
          point.z() != defaultZValue() )

diff --git a/src/providers/wfs/qgsoapifcollection.cpp b/src/providers/wfs/qgsoapifcollection.cpp
@@ -385,7 +385,7 @@ void QgsOapifCollectionsRequest::processReply()
       const auto collections = j["collections"];
       if ( collections.is_array() )
       {
-        for ( const auto jCollection : collections )
+        for ( const auto &jCollection : collections )
         {
           QgsOapifCollection collection;
           if ( collection.deserialize( jCollection ) )

diff --git a/tests/src/analysis/testqgsprocessingalgs.cpp b/tests/src/analysis/testqgsprocessingalgs.cpp
@@ -4535,7 +4535,7 @@ void TestQgsProcessingAlgs::exportAtlasLayoutPng()
   {
     QDir dir( QDir::tempPath() + "/my_atlas" );
     const QStringList files = dir.entryList( QStringList() << "*.*", QDir::Files );
-    for ( const QString file : files )
+    for ( const QString &file : files )
       QFile::remove( QDir::tempPath() + "/my_atlas/" + file );
   }