Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Address reviews
  • Loading branch information
NEDJIMAbelgacem authored and wonder-sk committed Dec 7, 2020
1 parent a536fde commit e11f64e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/3d/shaders/pointcloud.frag
Expand Up @@ -83,15 +83,15 @@ vec4 exactColorRamp()
if ( abs( parameter - value ) < 0.01 )
return vec4( color, 1.0f );
}
return vec4(0.0, 0.0, 0.0, 0.0f);
return vec4(0.0, 0.0, 0.0, 1.0f);
}

vec4 colorRamp()
{
if (u_colorRampCount<=0)
return vec4(0.0,0.0,0.0,1);

vec4 colorRampResult = vec4(0.0f, 0.0f, 0.0f, 0.0f);
vec4 colorRampResult = vec4(0.0f, 0.0f, 0.0f, 1.0f);
switch (u_colorRampType)
{
case 0:
Expand All @@ -113,7 +113,7 @@ void main(void)
switch (u_renderingStyle)
{
case 0: // no rendering
color = vec4(0.0f, 0.0f, 0.0f, 0.0f);
color = vec4(0.0f, 0.0f, 0.0f, 1.0f);
break;
case 1: // single color
color = vec4(u_singleColor, 1.0f);
Expand Down
4 changes: 2 additions & 2 deletions src/3d/symbols/qgspointcloud3dsymbol_p.cpp
Expand Up @@ -301,7 +301,7 @@ bool QgsColorRampPointCloud3DSymbolHandler::prepare( const QgsPointCloud3DRender
void QgsColorRampPointCloud3DSymbolHandler::processNode( QgsPointCloudIndex *pc, const IndexedPointCloudNode &n, const QgsPointCloud3DRenderContext &context )
{
QgsPointCloudAttributeCollection attributes;
constexpr int xOffset = 0;
const int xOffset = 0;
attributes.push_back( QgsPointCloudAttribute( QStringLiteral( "X" ), QgsPointCloudAttribute::Int32 ) );
const int yOffset = attributes.pointRecordSize();
attributes.push_back( QgsPointCloudAttribute( QStringLiteral( "Y" ), QgsPointCloudAttribute::Int32 ) );
Expand Down Expand Up @@ -536,7 +536,7 @@ bool QgsClassificationPointCloud3DSymbolHandler::prepare( const QgsPointCloud3DR
void QgsClassificationPointCloud3DSymbolHandler::processNode( QgsPointCloudIndex *pc, const IndexedPointCloudNode &n, const QgsPointCloud3DRenderContext &context )
{
QgsPointCloudAttributeCollection attributes;
constexpr int xOffset = 0;
const int xOffset = 0;
attributes.push_back( QgsPointCloudAttribute( QStringLiteral( "X" ), QgsPointCloudAttribute::Int32 ) );
const int yOffset = attributes.pointRecordSize();
attributes.push_back( QgsPointCloudAttribute( QStringLiteral( "Y" ), QgsPointCloudAttribute::Int32 ) );
Expand Down

0 comments on commit e11f64e

Please sign in to comment.