Fixes segfault in QgsSettings::clear, fixes #16233

elpaso · elpaso · commit e045b369cf6c · 2017-03-02T08:13:24.000+01:00
mGlobalSettings is read-only and can be a nullptr
that QSettings instance should never be modified
nor assumed to be instanciated
diff --git a/src/core/qgssettings.cpp b/src/core/qgssettings.cpp
@@ -182,7 +182,7 @@ void QgsSettings::sync()
 
 void QgsSettings::remove( const QString &key )
 {
-  mGlobalSettings->remove( key );
+  mUserSettings->remove( key );
 }
 
 QString QgsSettings::prefixedKey( const QString &key, const Section section ) const

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ void QgsSettings::sync()`
`182`	`182`
`183`	`183`	`void QgsSettings::remove( const QString &key )`
`184`	`184`	`{`
`185`		`- mGlobalSettings->remove( key );`
	`185`	`+ mUserSettings->remove( key );`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`QString QgsSettings::prefixedKey( const QString &key, const Section section ) const`