Skip to content

Commit

Permalink
Fixes segfault in QgsSettings::clear, fixes #16233
Browse files Browse the repository at this point in the history
mGlobalSettings is read-only and can be a nullptr
that QSettings instance should never be modified
nor assumed to be instanciated
  • Loading branch information
elpaso committed Mar 2, 2017
1 parent 1752d44 commit e045b36
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/qgssettings.cpp
Expand Up @@ -182,7 +182,7 @@ void QgsSettings::sync()

void QgsSettings::remove( const QString &key )
{
mGlobalSettings->remove( key );
mUserSettings->remove( key );
}

QString QgsSettings::prefixedKey( const QString &key, const Section section ) const
Expand Down

1 comment on commit e045b36

@elpaso
Copy link
Contributor Author

@elpaso elpaso commented on e045b36 Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit message, the fix was obviously in remove function

Please sign in to comment.