[server] Fix crash in WMS server when... bad things happen

m-kuhn · m-kuhn · commit dfef36e43f92 · 2016-07-12T19:30:58.000+02:00
No idea what exactly the reason is, and it was only discovered by
countless hours of printf-debugging. So I'm just pushing the fix
for everyone else who might be affected.
diff --git a/src/server/qgswmsprojectparser.cpp b/src/server/qgswmsprojectparser.cpp
@@ -1146,6 +1146,11 @@ void QgsWMSProjectParser::addLayers( QDomDocument &doc,
         }
       }
 
+      if ( !ltGroup )
+      {
+        QgsDebugMsg( QString( "Skipping group %1, it could not be found" ).arg( name ) );
+        continue;
+      }
       QString shortName = ltGroup->customProperty( "wmsShortName" ).toString();
       QString title = ltGroup->customProperty( "wmsTitle" ).toString();
 

Original file line number	Diff line number	Diff line change
`@@ -1146,6 +1146,11 @@ void QgsWMSProjectParser::addLayers( QDomDocument &doc,`
`1146`	`1146`	`}`
`1147`	`1147`	`}`
`1148`	`1148`
	`1149`	`+ if ( !ltGroup )`
	`1150`	`+ {`
	`1151`	`+ QgsDebugMsg( QString( "Skipping group %1, it could not be found" ).arg( name ) );`
	`1152`	`+ continue;`
	`1153`	`+ }`
`1149`	`1154`	`QString shortName = ltGroup->customProperty( "wmsShortName" ).toString();`
`1150`	`1155`	`QString title = ltGroup->customProperty( "wmsTitle" ).toString();`
`1151`	`1156`