Fix select by rectangle and by point in presence of rotation

Sandro Santilli · Sandro Santilli · commit df49538298c7 · 2015-01-03T17:24:39.000+01:00
Closes http://hub.qgis.org/issues/11865 and http://hub.qgis.org/issues/11930
diff --git a/src/app/qgsmaptoolselectutils.cpp b/src/app/qgsmaptoolselectutils.cpp
@@ -49,15 +49,17 @@ void QgsMapToolSelectUtils::setRubberBand( QgsMapCanvas* canvas, QRect& selectRe
 {
   const QgsMapToPixel* transform = canvas->getCoordinateTransform();
   QgsPoint ll = transform->toMapCoordinates( selectRect.left(), selectRect.bottom() );
+  QgsPoint lr = transform->toMapCoordinates( selectRect.right(), selectRect.bottom() );
+  QgsPoint ul = transform->toMapCoordinates( selectRect.left(), selectRect.top() );
   QgsPoint ur = transform->toMapCoordinates( selectRect.right(), selectRect.top() );
 
   if ( rubberBand )
   {
     rubberBand->reset( QGis::Polygon );
     rubberBand->addPoint( ll, false );
-    rubberBand->addPoint( QgsPoint( ur.x(), ll.y() ), false );
+    rubberBand->addPoint( lr, false );
     rubberBand->addPoint( ur, false );
-    rubberBand->addPoint( QgsPoint( ll.x(), ur.y() ), true );
+    rubberBand->addPoint( ul, true );
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,15 +49,17 @@ void QgsMapToolSelectUtils::setRubberBand( QgsMapCanvas* canvas, QRect& selectRe`
`49`	`49`	`{`
`50`	`50`	`const QgsMapToPixel* transform = canvas->getCoordinateTransform();`
`51`	`51`	`QgsPoint ll = transform->toMapCoordinates( selectRect.left(), selectRect.bottom() );`
	`52`	`+ QgsPoint lr = transform->toMapCoordinates( selectRect.right(), selectRect.bottom() );`
	`53`	`+ QgsPoint ul = transform->toMapCoordinates( selectRect.left(), selectRect.top() );`
`52`	`54`	`QgsPoint ur = transform->toMapCoordinates( selectRect.right(), selectRect.top() );`
`53`	`55`
`54`	`56`	`if ( rubberBand )`
`55`	`57`	`{`
`56`	`58`	`rubberBand->reset( QGis::Polygon );`
`57`	`59`	`rubberBand->addPoint( ll, false );`
`58`		`- rubberBand->addPoint( QgsPoint( ur.x(), ll.y() ), false );`
	`60`	`+ rubberBand->addPoint( lr, false );`
`59`	`61`	`rubberBand->addPoint( ur, false );`
`60`		`- rubberBand->addPoint( QgsPoint( ll.x(), ur.y() ), true );`
	`62`	`+ rubberBand->addPoint( ul, true );`
`61`	`63`	`}`
`62`	`64`	`}`
`63`	`65`