Skip to content

Commit dd61445

Browse files
committedJan 19, 2017
Reenable full task manager tests following b45469f
1 parent 16eac9f commit dd61445

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed
 

‎tests/src/core/testqgstaskmanager.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,7 @@ class TestQgsTaskManager : public QObject
193193
void task();
194194
void taskResult();
195195
void taskFinished();
196-
#if 0 //flaky
197196
void subTask();
198-
#endif
199197
void addTask();
200198
void taskTerminationBeforeDelete();
201199
void taskId();
@@ -432,7 +430,6 @@ void TestQgsTaskManager::taskFinished()
432430
QCOMPARE( *resultObtained, false );
433431
}
434432

435-
#if 0 //flaky
436433
void TestQgsTaskManager::subTask()
437434
{
438435
QgsTaskManager manager;
@@ -631,7 +628,6 @@ void TestQgsTaskManager::subTask()
631628
flushEvents();
632629
QVERIFY( parentFinished2.count() > 0 );
633630
}
634-
#endif
635631

636632
void TestQgsTaskManager::taskId()
637633
{
@@ -1073,7 +1069,7 @@ void TestQgsTaskManager::managerWithSubTasks()
10731069
QCOMPARE( manager->activeTasks().count(), 1 );
10741070
QVERIFY( manager->activeTasks().contains( parent ) );
10751071
QCOMPARE( spy.count(), 1 );
1076-
#if 0 // flaky
1072+
10771073
//manager should not directly listen to progress reports from subtasks
10781074
//(only parent tasks, which themselves include their subtask progress)
10791075
QCOMPARE( spyProgress.count(), 0 );
@@ -1094,7 +1090,6 @@ void TestQgsTaskManager::managerWithSubTasks()
10941090
QCOMPARE( spyProgress.count(), 3 );
10951091
QCOMPARE( spyProgress.last().at( 0 ).toLongLong(), 0LL );
10961092
QCOMPARE( spyProgress.last().at( 1 ).toInt(), 63 );
1097-
#endif
10981093

10991094
//manager should not emit statusChanged signals for subtasks
11001095
QSignalSpy statusSpy( manager, &QgsTaskManager::statusChanged );

0 commit comments

Comments
 (0)
Please sign in to comment.