more qml fixes

jef · jef · commit dcaaea9f711a · 2008-12-07T04:10:56.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@9748 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgsvectorlayerproperties.cpp b/src/app/qgsvectorlayerproperties.cpp
@@ -101,23 +101,9 @@ QgsVectorLayerProperties::QgsVectorLayerProperties(
   actionDialog = new QgsAttributeActionDialog( layer->actions(), fields, actionOptionsFrame );
   actionLayout->addWidget( actionDialog );
 
-  tblAttributes->setColumnCount( 8 );
-  tblAttributes->setRowCount( fields.size() );
-  tblAttributes->setHorizontalHeaderItem( 0, new QTableWidgetItem( tr( "id" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 1, new QTableWidgetItem( tr( "name" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 2, new QTableWidgetItem( tr( "type" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 3, new QTableWidgetItem( tr( "length" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 4, new QTableWidgetItem( tr( "precision" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 5, new QTableWidgetItem( tr( "comment" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 6, new QTableWidgetItem( tr( "edit widget" ) ) );
-  tblAttributes->setHorizontalHeaderItem( 7, new QTableWidgetItem( tr( "values" ) ) );
-
-  tblAttributes->setSelectionBehavior( QAbstractItemView::SelectRows );
-  tblAttributes->setSelectionMode( QAbstractItemView::MultiSelection );
-
-  loadRows();
 
   reset();
+
   if ( layer->dataProvider() )//enable spatial index button group if supported by provider
   {
     int capabilities = layer->dataProvider()->capabilities();
@@ -141,6 +127,22 @@ void QgsVectorLayerProperties::loadRows()
 {
   const QgsFieldMap &fields = layer->pendingFields();
 
+  tblAttributes->clear();
+
+  tblAttributes->setColumnCount( 8 );
+  tblAttributes->setRowCount( fields.size() );
+  tblAttributes->setHorizontalHeaderItem( 0, new QTableWidgetItem( tr( "id" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 1, new QTableWidgetItem( tr( "name" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 2, new QTableWidgetItem( tr( "type" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 3, new QTableWidgetItem( tr( "length" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 4, new QTableWidgetItem( tr( "precision" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 5, new QTableWidgetItem( tr( "comment" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 6, new QTableWidgetItem( tr( "edit widget" ) ) );
+  tblAttributes->setHorizontalHeaderItem( 7, new QTableWidgetItem( tr( "values" ) ) );
+
+  tblAttributes->setSelectionBehavior( QAbstractItemView::SelectRows );
+  tblAttributes->setSelectionMode( QAbstractItemView::MultiSelection );
+
   int row = 0;
   for ( QgsFieldMap::const_iterator it = fields.begin(); it != fields.end(); it++, row++ )
     setRow( row, it.key(), it.value() );
@@ -450,6 +452,7 @@ void QgsVectorLayerProperties::reset( void )
   //update the transparency percentage label
   sliderTransparency_valueChanged( 255 - layer->getTransparency() );
 
+  loadRows();
 } // reset()
 
 
diff --git a/src/core/qgslabel.cpp b/src/core/qgslabel.cpp
@@ -712,7 +712,9 @@ bool QgsLabel::readLabelField( QDomElement &el, int attr, QString prefix = "fiel
   }
   else if ( el.hasAttribute( prefix ) )
   {
-    mLabelFieldIdx[attr] = el.attribute( prefix ).toInt();
+    QString value = el.attribute( prefix );
+    mLabelFieldIdx[attr] = value.isEmpty() ? -1 : value.toInt();
+    return true;
   }
 
   mLabelFieldIdx[attr] = -1;
@@ -768,7 +770,7 @@ void QgsLabel::readXML( const QDomNode& node )
   else
   {
     el = scratchNode.toElement();
-    if ( !el.hasAttribute( "unitfieldname" ) )
+    if ( !el.hasAttribute( "unitfield" ) && !el.hasAttribute( "unitfieldname" ) )
     {
       type = QgsLabelAttributes::unitsCode( el.attribute( "units", "" ) );
       mLabelAttributes->setSize( el.attribute( "value", "0.0" ).toDouble(), type );

Original file line number	Diff line number	Diff line change
`@@ -712,7 +712,9 @@ bool QgsLabel::readLabelField( QDomElement &el, int attr, QString prefix = "fiel`
`712`	`712`	`}`
`713`	`713`	`else if ( el.hasAttribute( prefix ) )`
`714`	`714`	`{`
`715`		`- mLabelFieldIdx[attr] = el.attribute( prefix ).toInt();`
	`715`	`+ QString value = el.attribute( prefix );`
	`716`	`+ mLabelFieldIdx[attr] = value.isEmpty() ? -1 : value.toInt();`
	`717`	`+ return true;`
`716`	`718`	`}`
`717`	`719`
`718`	`720`	`mLabelFieldIdx[attr] = -1;`
`@@ -768,7 +770,7 @@ void QgsLabel::readXML( const QDomNode& node )`
`768`	`770`	`else`
`769`	`771`	`{`
`770`	`772`	`el = scratchNode.toElement();`
`771`		`- if ( !el.hasAttribute( "unitfieldname" ) )`
	`773`	`+ if ( !el.hasAttribute( "unitfield" ) && !el.hasAttribute( "unitfieldname" ) )`
`772`	`774`	`{`
`773`	`775`	`type = QgsLabelAttributes::unitsCode( el.attribute( "units", "" ) );`
`774`	`776`	`mLabelAttributes->setSize( el.attribute( "value", "0.0" ).toDouble(), type );`