Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Revert "[processing] hide 'select file' button for vector layers when…
… there are dependent params" This reverts commit f204452. It's a contentious fix, which needs discussion
- Loading branch information
1 parent
bdf77ac
commit db3b9ae
Showing
1 changed file
with
18 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db3b9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nyall, can you explain why you reverted this? This just brings back the way it was in 2.X
There are other ways to fix this issue (as i wrote in the tracker), but I guess the best thing to do at the moment is just go to the old way of having that.
Thanks!
db3b9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volaya did you read my comment in the tracker from a couple of days ago? This already works as intended using your 2) method from the ticket.
db3b9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, right...I am seeing it works now. This is what happened to me: I was trying to use the "points from table" algorithm, and selected a csv file as table file. I guess it cannot load that file, and it was not populating anything.
It's ok with you if I add some sort of warning for that case? So if the selected file cannot be loaded in the background, the user knows that he might have selected something invalid
Thanks!
db3b9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable! Can you do it via a PR?
db3b9ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! Will put you as reviewer. Thanks!