correctly delete last digitized point, fixes #8462

qgis · Aug 13, 2013 · db07f2f · db07f2f
1 parent 441a46b
commit db07f2f
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 3 deletions.
diff --git a/src/app/qgsmaptoolcapture.cpp b/src/app/qgsmaptoolcapture.cpp
@@ -209,8 +209,9 @@ int QgsMapToolCapture::addVertex( const QPoint &p )
   {
     mTempRubberBand = createRubberBand( mCaptureMode == CapturePolygon ? QGis::Polygon : QGis::Line , true );
   }
-  else{
-    mTempRubberBand->reset(CapturePolygon ? true : false);
+  else
+  {
+    mTempRubberBand->reset( mCaptureMode == CapturePolygon ? true : false );
   }
   if ( mCaptureMode == CaptureLine )
   {
@@ -234,14 +235,29 @@ void QgsMapToolCapture::undo()
   if ( mRubberBand )
   {
     int rubberBandSize = mRubberBand->numberOfVertices();
+    int tempRubberBandSize = mTempRubberBand->numberOfVertices();
     int captureListSize = mCaptureList.size();
 
     if ( rubberBandSize < 1 || captureListSize < 1 )
     {
       return;
     }
 
-    mRubberBand->removePoint( -2 ); // remove the one before the last one
+    mRubberBand->removePoint( -1 );
+
+    if ( mRubberBand->numberOfVertices() > 0 )
+    {
+      if ( mTempRubberBand->numberOfVertices() > 1 )
+      {
+        const QgsPoint *point = mRubberBand->getPoint( 0, mRubberBand->numberOfVertices() - 1 );
+        mTempRubberBand->movePoint( mTempRubberBand->numberOfVertices() - 2, *point );
+      }
+    }
+    else
+    {
+      mTempRubberBand->reset( mCaptureMode == CapturePolygon ? true : false );
+    }
+
     mCaptureList.removeLast();
 
     validateGeometry();

diff --git a/src/gui/qgsrubberband.cpp b/src/gui/qgsrubberband.cpp
@@ -536,6 +536,12 @@ int QgsRubberBand::size() const
   return mPoints.size();
 }
 
+int QgsRubberBand::partSize( int geometryIndex ) const
+{
+  if ( geometryIndex < 0 || geometryIndex >= mPoints.size() ) return 0;
+  return mPoints[geometryIndex].size();
+}
+
 int QgsRubberBand::numberOfVertices() const
 {
   int count = 0;

diff --git a/src/gui/qgsrubberband.h b/src/gui/qgsrubberband.h
@@ -163,6 +163,13 @@ class GUI_EXPORT QgsRubberBand: public QgsMapCanvasItem
      */
     void movePoint( int index, const QgsPoint& p, int geometryIndex = 0 );
 
+    /**
+     * Returns number of vertices in feature part
+     *  @param geometryIndex The index of the feature part (in case of multipart geometries)
+     *  @return number of vertices
+     */
+    int partSize( int geometryIndex ) const;
+
     /**
      * Sets this rubber band to the geometry of an existing feature.
      * This is useful for feature highlighting.