use default QString() constructor instead of ""

improve doxygen docs
qgis · Nov 2, 2016 · dac03d5 · dac03d5
1 parent 75b23cb
commit dac03d5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/python/core/raster/qgscolorrampshader.sip b/python/core/raster/qgscolorrampshader.sip
@@ -42,6 +42,7 @@ class QgsColorRampShader : QgsRasterShaderFunction
 
     /** \brief Get the original color ramp name
      * @note added in QGIS 3.0
+     * @see setColorRampName()
      */
     QString colorRampName() const;
 
@@ -53,6 +54,7 @@ class QgsColorRampShader : QgsRasterShaderFunction
 
     /** \brief Set the source color ramp name
      * @note added in QGIS 3.0
+     * @see colorRampName()
      */
     void setColorRampName( const QString& theName );
 

diff --git a/src/core/raster/qgscolorrampshader.cpp b/src/core/raster/qgscolorrampshader.cpp
@@ -34,8 +34,8 @@ QgsColorRampShader::QgsColorRampShader( double theMinimumValue, double theMaximu
     , mLUTOffset( 0.0 )
     , mLUTFactor( 1.0 )
     , mLUTInitialized( false )
+    , mColorRampName( QString() )
     , mClip( false )
-    , mColorRampName( "" )
 {
   QgsDebugMsgLevel( "called.", 4 );
 }

diff --git a/src/core/raster/qgscolorrampshader.h b/src/core/raster/qgscolorrampshader.h
@@ -77,6 +77,7 @@ class CORE_EXPORT QgsColorRampShader : public QgsRasterShaderFunction
 
     /** \brief Get the original color ramp name
      * @note added in QGIS 3.0
+     * @see setColorRampName()
      */
     QString colorRampName() const {return mColorRampName;}
 
@@ -88,6 +89,7 @@ class CORE_EXPORT QgsColorRampShader : public QgsRasterShaderFunction
 
     /** \brief Set the source color ramp name
      * @note added in QGIS 3.0
+     * @see colorRampName()
      */
     void setColorRampName( const QString& theName );
 

diff --git a/src/core/raster/qgsrastershader.cpp b/src/core/raster/qgsrastershader.cpp
@@ -170,7 +170,7 @@ void QgsRasterShader::readXml( const QDomElement& elem )
   if ( !colorRampShaderElem.isNull() )
   {
     QgsColorRampShader* colorRampShader = new QgsColorRampShader();
-    colorRampShader->setColorRampName( colorRampShaderElem.attribute( "colorRampName", "" ) );
+    colorRampShader->setColorRampName( colorRampShaderElem.attribute( "colorRampName", QString() ) );
     colorRampShader->setColorRampType( colorRampShaderElem.attribute( QStringLiteral( "colorRampType" ), QStringLiteral( "INTERPOLATED" ) ) );
     colorRampShader->setClip( colorRampShaderElem.attribute( QStringLiteral( "clip" ), QStringLiteral( "0" ) ) == QLatin1String( "1" ) );