Simplify QgsHanaConnection::getSchemas

qgis · Dec 9, 2020 · da95974 · da95974
1 parent e03ea84
commit da95974
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/providers/hana/qgshanaconnection.cpp b/src/providers/hana/qgshanaconnection.cpp
@@ -572,10 +572,7 @@ QVector<QgsHanaSchemaProperty> QgsHanaConnection::getSchemas( const QString &own
     QgsHanaResultSetRef rsSchemas = QgsHanaResultSet::create( stmt );
     while ( rsSchemas->next() )
     {
-      QgsHanaSchemaProperty schema;
-      schema.name = rsSchemas->getString( 1 );
-      schema.owner = rsSchemas->getString( 2 );
-      list << schema;
+      list.push_back( {rsSchemas->getString( 1 ), rsSchemas->getString( 2 )} );
     }
     rsSchemas->close();
   }

diff --git a/src/providers/hana/qgshanaproviderconnection.cpp b/src/providers/hana/qgshanaproviderconnection.cpp
@@ -355,8 +355,8 @@ QStringList QgsHanaProviderConnection::schemas( ) const
   try
   {
     QStringList schemas;
-    QVector<QgsHanaSchemaProperty> schemaProperties = conn->getSchemas( "" );
-    for ( const auto &s : qgis::as_const( schemaProperties ) )
+    const QVector<QgsHanaSchemaProperty> schemaProperties = conn->getSchemas( QString() );
+    for ( const QgsHanaSchemaProperty &s : schemaProperties )
       schemas.push_back( s.name );
     return schemas;
   }