Expression callTips are lowercase

Expressions are case insensitive but in all the apis and samples lower case is used. Be conform.
qgis · Sep 9, 2018 · da7cc96 · da7cc96
1 parent 4b9cc9b
commit da7cc96
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/gui/qgscodeeditorexpression.cpp b/src/gui/qgscodeeditorexpression.cpp
@@ -118,7 +118,7 @@ void QgsCodeEditorExpression::initializeLexer()
 
 void QgsCodeEditorExpression::updateApis()
 {
-  mApis = new QsciAPIs( mSqlLexer );
+  mApis = new QgsSciApisExpression( mSqlLexer );
 
   for ( const QString &var : qgis::as_const( mVariables ) )
   {
@@ -164,4 +164,20 @@ const char *QgsLexerExpression::wordCharacters() const
 {
   return "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_@";
 }
+
+QgsSciApisExpression::QgsSciApisExpression( QsciLexer *lexer )
+  : QsciAPIs( lexer )
+{
+
+}
+
+QStringList QgsSciApisExpression::callTips( const QStringList &context, int commas, QsciScintilla::CallTipsStyle style, QList<int> &shifts )
+{
+  const QStringList originalTips = QsciAPIs::callTips( context, commas, style, shifts );
+  QStringList lowercaseTips;
+  for ( const QString &tip : originalTips )
+    lowercaseTips << tip.toLower();
+
+  return lowercaseTips;
+}
 ///@endcond
diff --git a/src/gui/qgscodeeditorexpression.h b/src/gui/qgscodeeditorexpression.h
@@ -91,6 +91,14 @@ class QgsLexerExpression : public QsciLexerSQL
 
     const char *wordCharacters() const override;
 };
+
+class QgsSciApisExpression : public QsciAPIs
+{
+  public:
+    QgsSciApisExpression( QsciLexer *lexer );
+
+    QStringList callTips( const QStringList &context, int commas, QsciScintilla::CallTipsStyle style, QList<int> &shifts ) override;
+};
 ///@endcond
 #endif