block vector layer signals when updating attribute values from field …

…calculator (fixes #7190)
qgis · Feb 22, 2013 · da60fe1 · da60fe1
1 parent b4e7228
commit da60fe1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/app/qgsfieldcalculator.cpp b/src/app/qgsfieldcalculator.cpp
@@ -184,7 +184,10 @@ void QgsFieldCalculator::accept()
     }
     else
     {
+      // FIXME workaround while QgsVectorLayer::changeAttributeValue's emitSignal is ignored (see #7190)
+      mVectorLayer->blockSignals( true );
       mVectorLayer->changeAttributeValue( feature.id(), mAttributeId, value, false );
+      mVectorLayer->blockSignals( false );
     }
 
     rownum++;

diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -3175,7 +3175,7 @@ bool QgsVectorLayer::changeGeometry( QgsFeatureId fid, QgsGeometry* geom )
 
 bool QgsVectorLayer::changeAttributeValue( QgsFeatureId fid, int field, QVariant value, bool emitSignal )
 {
-  Q_UNUSED( emitSignal ); // TODO[MD]
+  Q_UNUSED( emitSignal ); // TODO[MD] - see also QgsFieldCalculator and #7190
   if ( !mEditBuffer || !mDataProvider )
     return false;