Skip to content

Commit

Permalink
PeterP review
Browse files Browse the repository at this point in the history
  • Loading branch information
wonder-sk committed Sep 9, 2021
1 parent ed04756 commit d9348db
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
4 changes: 1 addition & 3 deletions src/providers/mssql/qgsmssqltransaction.cpp
Expand Up @@ -30,9 +30,7 @@ QgsMssqlTransaction::QgsMssqlTransaction( const QString &connString )
{
}

QgsMssqlTransaction::~QgsMssqlTransaction()
{
}
QgsMssqlTransaction::~QgsMssqlTransaction() = default;


bool QgsMssqlTransaction::executeSql( const QString &sql, QString &error, bool isDirty, const QString &name )
Expand Down
2 changes: 1 addition & 1 deletion tests/src/providers/CMakeLists.txt
Expand Up @@ -40,7 +40,7 @@ add_qgis_test(testqgspostgresexpressioncompiler.cpp MODULE provider LINKEDLIBRAR
add_qgis_test(testqgspostgresprovider.cpp MODULE provider LINKEDLIBRARIES provider_postgres_a qgis_core)
add_qgis_test(testqgspostgresconn.cpp MODULE provider LINKEDLIBRARIES provider_postgres_a qgis_core LABELS "POSTGRES")

set(ENABLE_MSSQLTEST_CPP FALSE CACHE BOOL "Enable MsSQL provider C++ tests")
set(ENABLE_MSSQLTEST_CPP FALSE CACHE BOOL "Enable MSSQL provider C++ tests")
if (ENABLE_MSSQLTEST_CPP)
add_qgis_test(testqgsmssqlprovider.cpp MODULE provider LINKEDLIBRARIES provider_mssql_a qgis_core LABELS "MSSQL")
# also depend on dynamic lib, so that building this test will also build the dynamic lib
Expand Down
2 changes: 1 addition & 1 deletion tests/src/providers/testqgsmssqlprovider.cpp
@@ -1,5 +1,5 @@
/***************************************************************************
testqgsmssqlprovider.cpp - %{Cpp:License:ClassName}
testqgsmssqlprovider.cpp
---------------------
begin : 16.3.2021
copyright : (C) 2021 by Vincent Cloarec
Expand Down
2 changes: 1 addition & 1 deletion tests/src/python/CMakeLists.txt
@@ -1,4 +1,4 @@
set (ENABLE_MSSQLTEST FALSE CACHE BOOL "Enable MsSQL provider tests")
set (ENABLE_MSSQLTEST FALSE CACHE BOOL "Enable MSSQL provider tests")
set (ENABLE_ORACLETEST FALSE CACHE BOOL "Enable Oracle provider tests")
set (ENABLE_HANATEST FALSE CACHE BOOL "Enable HANA provider tests")

Expand Down

0 comments on commit d9348db

Please sign in to comment.