Skip to content

Commit d8f6fd0

Browse files
committedMay 22, 2014
Fix combo name in fielc calc bar
1 parent c234a09 commit d8f6fd0

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎src/app/qgsattributetabledialog.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ QgsAttributeTableDialog::QgsAttributeTableDialog( QgsVectorLayer *theLayer, QWid
157157
mAttributeViewButton->setIcon( QgsApplication::getThemeIcon( "/mActionPropertyItem.png" ) );
158158
mExpressionSelectButton->setIcon( QgsApplication::getThemeIcon( "/mIconExpressionSelect.svg" ) );
159159
mAddFeature->setIcon( QgsApplication::getThemeIcon( "/mActionNewTableRow.png" ) );
160+
mOpenExpressionWidget->setIcon( QgsApplication::getThemeIcon( "/mIconExpression.svg" ) );
160161

161162
// toggle editing
162163
bool canChangeAttributes = mLayer->dataProvider()->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;
@@ -203,7 +204,7 @@ QgsAttributeTableDialog::QgsAttributeTableDialog( QgsVectorLayer *theLayer, QWid
203204

204205
mFieldModel = new QgsFieldModel();
205206
mFieldModel->setLayer( mLayer );
206-
mFieldComboButton->setModel( mFieldModel );
207+
mFieldCombo->setModel( mFieldModel );
207208
connect( mOpenExpressionWidget, SIGNAL( clicked() ), this, SLOT( openExpressionBuilder() ) );
208209
connect( mRunFieldCalc, SIGNAL( clicked() ), this, SLOT( updateFieldFromExpression() ) );
209210
editingToggled();
@@ -294,7 +295,7 @@ void QgsAttributeTableDialog::updateFieldFromExpression()
294295

295296
mLayer->beginEditCommand( "Field calculator" );
296297

297-
QModelIndex modelindex = mFieldModel->indexFromName( mFieldComboButton->currentText() );
298+
QModelIndex modelindex = mFieldModel->indexFromName( mFieldCombo->currentText() );
298299
int fieldindex = modelindex.data( QgsFieldModel::FieldIndexRole ).toInt();
299300

300301
bool calculationSuccess = true;

‎src/ui/qgsattributetabledialog.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@
551551
<number>1</number>
552552
</property>
553553
<item>
554-
<widget class="QComboBox" name="mFieldComboButton"/>
554+
<widget class="QComboBox" name="mFieldCombo"/>
555555
</item>
556556
<item>
557557
<widget class="QLabel" name="label">

0 commit comments

Comments
 (0)
Please sign in to comment.