Move deprecated plugins to the list bottom

borysiasty · borysiasty · commit d838d63e1fed · 2018-09-14T17:37:55.000+02:00
diff --git a/src/app/pluginmanager/qgspluginsortfilterproxymodel.cpp b/src/app/pluginmanager/qgspluginsortfilterproxymodel.cpp
@@ -151,3 +151,24 @@ void QgsPluginSortFilterProxyModel::sortPluginsByStatus()
   sort( 0, Qt::DescendingOrder );
   setSortRole( PLUGIN_STATUS_ROLE );
 }
+
+
+
+bool QgsPluginSortFilterProxyModel::lessThan( const QModelIndex &source_left, const QModelIndex &source_right ) const
+{
+  // Always move deprecated plugins to bottom, regardless of the sort order.
+  const bool isLeftDepreciated = sourceModel()->data( source_left, PLUGIN_ISDEPRECATED_ROLE ).toString() == QStringLiteral( "true" );
+  const bool isRightDepreciated = sourceModel()->data( source_right, PLUGIN_ISDEPRECATED_ROLE ).toString() == QStringLiteral( "true" );
+  if ( isRightDepreciated && !isLeftDepreciated )
+  {
+    return sortOrder() == Qt::AscendingOrder ? true : false;
+  }
+  else if ( isLeftDepreciated && !isRightDepreciated )
+  {
+    return sortOrder() == Qt::AscendingOrder ? false : true;
+  }
+  else
+  {
+    return QSortFilterProxyModel::lessThan( source_left, source_right );
+  }
+}
diff --git a/src/app/pluginmanager/qgspluginsortfilterproxymodel.h b/src/app/pluginmanager/qgspluginsortfilterproxymodel.h
@@ -70,6 +70,9 @@ class QgsPluginSortFilterProxyModel : public QSortFilterProxyModel
     //! The main filter method
     bool filterAcceptsRow( int sourceRow, const QModelIndex &sourceParent ) const override;
 
+    //! The sort method overwritten in order to always display deprecated plugins last.
+    bool lessThan( const QModelIndex &source_left, const QModelIndex &source_right ) const override;
+
   private:
     QStringList mAcceptedStatuses;
     QString mAcceptedSpacers;
