Apply suggestions from code review

Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
qgis · Sep 24, 2020 · d7b9e0b · d7b9e0b
1 parent f87fb04
commit d7b9e0b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/app/locator/qgsinbuiltlocatorfilters.cpp b/src/app/locator/qgsinbuiltlocatorfilters.cpp
@@ -262,7 +262,7 @@ QStringList QgsActiveLayerFeaturesLocatorFilter::prepare( const QString &string,
   mFieldsCompletion.clear();
 
   // Normally skip very short search strings, unless when specifically searching using this filter or try to match fields
-  if ( string.length() < 3 && !context.usingPrefix && !string.startsWith( QStringLiteral( "@" ) ) )
+  if ( string.length() < 3 && !context.usingPrefix && !string.startsWith( '@' ) ) )
     return QStringList();
 
   QgsSettings settings;
@@ -1133,4 +1133,3 @@ void QgsGotoLocatorFilter::triggerResult( const QgsLocatorResult &result )
 
   mapCanvas->flashGeometries( QList< QgsGeometry >() << QgsGeometry::fromPointXY( point ) );
 }
-
diff --git a/tests/src/app/testqgsapplocatorfilters.cpp b/tests/src/app/testqgsapplocatorfilters.cpp
@@ -224,7 +224,7 @@ void TestQgsAppLocatorFilters::testActiveLayerFieldRestriction()
   search = QStringLiteral( "@" );
   restr = QgsActiveLayerFeaturesLocatorFilter::fieldRestriction( search );
   QVERIFY( !restr.isNull() );
-  QCOMPARE( search, QStringLiteral( "" ) );
+  QCOMPARE( search, QString() );
 
   search = QStringLiteral( "hello there" );
   restr = QgsActiveLayerFeaturesLocatorFilter::fieldRestriction( search );