Apply suggestions from code review

qgis · Oct 29, 2021 · d725248 · d725248
1 parent 5969ae2
commit d725248
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/gui/raster/qgsrendererrasterpropertieswidget.cpp b/src/gui/raster/qgsrendererrasterpropertieswidget.cpp
@@ -296,7 +296,7 @@ void QgsRendererRasterPropertiesWidget::setRendererWidget( const QString &render
       const QgsRectangle myExtent = mMapCanvas->mapSettings().outputExtentToLayerExtent( mRasterLayer, mMapCanvas->extent() );
       if ( oldWidget )
       {
-        QgsRasterRenderer *oldRenderer = oldWidget->renderer();
+        std::unique_ptr< QgsRasterRenderer > oldRenderer( oldWidget->renderer() );
         if ( !oldRenderer || oldRenderer->type() != rendererName )
         {
           if ( rendererName == QLatin1String( "singlebandgray" ) )
@@ -310,7 +310,6 @@ void QgsRendererRasterPropertiesWidget::setRendererWidget( const QString &render
             whileBlocking( mRasterLayer )->setDefaultContrastEnhancement();
           }
         }
-        delete oldRenderer;
       }
       mRasterLayer->renderer()->setAlphaBand( alphaBand );
       mRasterLayer->renderer()->setOpacity( opacity );