Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #45287 from 3nids/avoid-copy
avoid copy in for loops
  • Loading branch information
rouault committed Sep 28, 2021
2 parents e2dd38e + b418264 commit d6ad32f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/core/layout/qgslayoutitemnodeitem.cpp
Expand Up @@ -181,7 +181,7 @@ void QgsLayoutNodesItem::drawNodes( QgsLayoutItemRenderContext &context ) const
symbol->setAngle( 45 );

symbol->startRender( context.renderContext() );
for ( const QPointF pt : mPolygon )
for ( const QPointF pt : std::as_const( mPolygon ) )
symbol->renderPoint( pt * context.viewScaleFactor(), nullptr, context.renderContext() );
symbol->stopRender( context.renderContext() );

Expand Down Expand Up @@ -219,7 +219,7 @@ int QgsLayoutNodesItem::nodeAtPosition( QPointF node,
int idx = -1;

int i = 0;
for ( const QPointF polyPt : mPolygon )
for ( const QPointF polyPt : std::as_const( mPolygon ) )
{
distance = computeDistance( pt, polyPt );
if ( distance < nearestDistance && distance < maxDistance )
Expand Down Expand Up @@ -360,7 +360,7 @@ bool QgsLayoutNodesItem::writePropertiesToElement( QDomElement &elem, QDomDocume

// write nodes
QDomElement nodesElem = doc.createElement( QStringLiteral( "nodes" ) );
for ( const QPointF pt : mPolygon )
for ( const QPointF pt : std::as_const( mPolygon ) )
{
QDomElement nodeElem = doc.createElement( QStringLiteral( "node" ) );
nodeElem.setAttribute( QStringLiteral( "x" ), QString::number( pt.x() ) );
Expand Down
2 changes: 1 addition & 1 deletion src/core/raster/qgsrasterlayer.cpp
Expand Up @@ -2230,7 +2230,7 @@ bool QgsRasterLayer::writeXml( QDomNode &layer_node,
noDataRangeList.setAttribute( QStringLiteral( "useSrcNoData" ), mDataProvider->useSourceNoDataValue( bandNo ) );

const auto constUserNoDataValues = mDataProvider->userNoDataValues( bandNo );
for ( const QgsRasterRange range : constUserNoDataValues )
for ( const QgsRasterRange &range : constUserNoDataValues )
{
QDomElement noDataRange = document.createElement( QStringLiteral( "noDataRange" ) );

Expand Down

0 comments on commit d6ad32f

Please sign in to comment.