Skip to content

Commit

Permalink
use "gpkg_fid" as default FID column
Browse files Browse the repository at this point in the history
  • Loading branch information
signedav committed Oct 22, 2018
1 parent b4da995 commit d3ccd6e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/core/qgsofflineediting.cpp
Expand Up @@ -638,9 +638,7 @@ QgsVectorLayer *QgsOfflineEditing::copyVectorLayer( QgsVectorLayer *layer, sqlit
options = CSLSetNameValue( options, "OVERWRITE", "YES" );
options = CSLSetNameValue( options, "IDENTIFIER", tr( "%1 (offline)" ).arg( layer->name() ).toUtf8().constData() );
options = CSLSetNameValue( options, "DESCRIPTION", layer->dataComment().toUtf8().constData() );
#if 0
options = CSLSetNameValue( options, "FID", featureId.toUtf8().constData() );
#endif
options = CSLSetNameValue( options, "FID", "gpkg_id" );

if ( layer->isSpatial() )
{
Expand Down Expand Up @@ -750,7 +748,7 @@ QgsVectorLayer *QgsOfflineEditing::copyVectorLayer( QgsVectorLayer *layer, sqlit
// fill gap in QgsAttributeMap if geometry column is not last (WORKAROUND)
QgsAttributes attrs = f.attributes();
int column = 0;
if ( containerType == GPKG && layer->dataProvider()->fields().lookupField( "fid" ) == -1 )
if ( containerType == GPKG && layer->dataProvider()->fields().lookupField( "gpkg_fid" ) == -1 )
{
// newAttrs has an addition FID attribute, so we have to add a dummy in the original set
column++;
Expand Down

0 comments on commit d3ccd6e

Please sign in to comment.