Cleanup all browser layer properties dialog before exiting (#54808)

These must be deleted before calling QgsApplication::exitQgis, or we get a crash Fixes #39094
qgis · Oct 3, 2023 · d2ee3eb · d2ee3eb
1 parent 4d9f3f8
commit d2ee3eb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -118,6 +118,7 @@
 #include "options/qgsrenderingoptions.h"
 #include "options/qgsvectorrenderingoptions.h"
 #include "options/qgsuserprofileoptions.h"
+#include "qgsbrowserdockwidget_p.h"
 
 #include "raster/qgsrasterelevationpropertieswidget.h"
 #include "qgsrasterattributetableapputils.h"
@@ -2152,6 +2153,13 @@ QgisApp::~QgisApp()
   deleteLayoutDesigners();
   removeAnnotationItems();
 
+  // these need to be gracefully cleaned up before QgsApplication::exitQgis()
+  const QList<QgsBrowserPropertiesDialog *> browserPropertyDialogs = findChildren< QgsBrowserPropertiesDialog * >();
+  for ( QgsBrowserPropertiesDialog *widget : browserPropertyDialogs )
+  {
+    delete widget;
+  }
+
   // cancel request for FileOpen events
   QgsApplication::setFileOpenEventReceiver( nullptr );