Fix Coverity logically dead code error

qgis · Apr 29, 2017 · d2a7c93 · d2a7c93
1 parent 4b4606f
commit d2a7c93
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -5839,13 +5839,18 @@ void QgisApp::saveMapAsImage()
     } );
     connect( mapRendererTask, &QgsMapRendererTask::errorOccurred, this, [ = ]( int error )
     {
-      if ( error == QgsMapRendererTask::ImageAllocationFail )
+      switch ( error )
       {
-        messageBar()->pushWarning( tr( "Save as image" ), tr( "Could not allocate required memory for image" ) );
-      }
-      else if ( error == QgsMapRendererTask::ImageAllocationFail )
-      {
-        messageBar()->pushWarning( tr( "Save as image" ), tr( "Could not save the image to file" ) );
+        case QgsMapRendererTask::ImageAllocationFail:
+        {
+          messageBar()->pushWarning( tr( "Save as image" ), tr( "Could not allocate required memory for image" ) );
+          break;
+        }
+        case QgsMapRendererTask::ImageSaveFail:
+        {
+          messageBar()->pushWarning( tr( "Save as image" ), tr( "Could not save the image to file" ) );
+          break;
+        }
       }
     } );