Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[layouts] Add inbuilt validity check to warn when scale bars are
not linked to a map item (and remove test Web mercator projection warning check)
- Loading branch information
1 parent
ddd522b
commit d14a5bd
Showing
5 changed files
with
132 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /*************************************************************************** | ||
| testqgsapplayoutvaliditychecks.cpp | ||
| -------------------------------------- | ||
| Date : January 2019 | ||
| Copyright : (C) 2019 Nyall Dawson | ||
| Email : nyall dot dawson at gmail dot com | ||
| *************************************************************************** | ||
| * * | ||
| * This program is free software; you can redistribute it and/or modify * | ||
| * it under the terms of the GNU General Public License as published by * | ||
| * the Free Software Foundation; either version 2 of the License, or * | ||
| * (at your option) any later version. * | ||
| * * | ||
| ***************************************************************************/ | ||
| #include "qgstest.h" | ||
|
|
||
| #include <QObject> | ||
| #include <QString> | ||
| #include <QStringList> | ||
|
|
||
| //qgis includes... | ||
| #include "qgsdataitem.h" | ||
| #include "qgsapplication.h" | ||
| #include "qgslogger.h" | ||
| #include "qgsproject.h" | ||
| #include "qgslayout.h" | ||
| #include "qgslayoutitemscalebar.h" | ||
| #include "qgslayoutitemmap.h" | ||
| #include "qgsabstractvaliditycheck.h" | ||
| #include "qgsvaliditycheckcontext.h" | ||
| #include "layout/qgslayoutvaliditychecks.h" | ||
| #include "qgsfeedback.h" | ||
|
|
||
| class TestQgsLayoutValidityChecks : public QObject | ||
| { | ||
| Q_OBJECT | ||
|
|
||
| public: | ||
| TestQgsLayoutValidityChecks(); | ||
|
|
||
| private slots: | ||
| void initTestCase();// will be called before the first testfunction is executed. | ||
| void cleanupTestCase();// will be called after the last testfunction was executed. | ||
| void init() {} // will be called before each testfunction is executed. | ||
| void cleanup() {} // will be called after every testfunction. | ||
|
|
||
| void testScaleBarValidity(); | ||
|
|
||
| private: | ||
| QString mTestDataDir; | ||
| }; | ||
|
|
||
| TestQgsLayoutValidityChecks::TestQgsLayoutValidityChecks() = default; | ||
|
|
||
| void TestQgsLayoutValidityChecks::initTestCase() | ||
| { | ||
| // | ||
| // Runs once before any tests are run | ||
| // | ||
| // init QGIS's paths - true means that all path will be inited from prefix | ||
| QgsApplication::init(); | ||
| QgsApplication::initQgis(); | ||
| QgsApplication::showSettings(); | ||
|
|
||
| QString dataDir( TEST_DATA_DIR ); //defined in CmakeLists.txt | ||
| mTestDataDir = dataDir + '/'; | ||
| } | ||
|
|
||
| void TestQgsLayoutValidityChecks::cleanupTestCase() | ||
| { | ||
| QgsApplication::exitQgis(); | ||
| } | ||
|
|
||
| void TestQgsLayoutValidityChecks::testScaleBarValidity() | ||
| { | ||
| QgsProject p; | ||
| QgsLayout l( &p ); | ||
|
|
||
| QgsLayoutItemScaleBar *scale = new QgsLayoutItemScaleBar( &l ); | ||
| l.addItem( scale ); | ||
|
|
||
| QgsLayoutValidityCheckContext context( &l ); | ||
| QgsFeedback f; | ||
|
|
||
| // scalebar not linked to map | ||
| QgsLayoutScaleBarValidityCheck check; | ||
| QVERIFY( check.prepareCheck( &context, &f ) ); | ||
| QList< QgsValidityCheckResult > res = check.runCheck( &context, &f ); | ||
| QCOMPARE( res.size(), 1 ); | ||
| QCOMPARE( res.at( 0 ).type, QgsValidityCheckResult::Warning ); | ||
|
|
||
| // now link a map | ||
| QgsLayoutItemMap *map = new QgsLayoutItemMap( &l ); | ||
| l.addItem( map ); | ||
| scale->setLinkedMap( map ); | ||
|
|
||
| QgsLayoutScaleBarValidityCheck check2; | ||
| QVERIFY( check2.prepareCheck( &context, &f ) ); | ||
| res = check2.runCheck( &context, &f ); | ||
| QCOMPARE( res.size(), 0 ); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| QGSTEST_MAIN( TestQgsLayoutValidityChecks ) | ||
| #include "testqgsapplayoutvaliditychecks.moc" |