[bugfix] Do not cache invalid WM(T)S responses

The problem here was that in case of http->https redirect from a misconfigured server (that advertizes http and then redirects all request to https) all http redirect requests were cached, making all subsequent requests to the same url hit the 301 Moved Permanently reponse page intead of the redirected content. Fixes #16427 WMTS rendering problems in 2.18 and Master
qgis · Oct 3, 2017 · d102404 · d102404
1 parent 22d4d22
commit d102404
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/providers/wms/qgstilecache.cpp b/src/providers/wms/qgstilecache.cpp
@@ -48,9 +48,12 @@ bool QgsTileCache::tile( const QUrl &url, QImage &image )
       image = QImage::fromData( imageData );
 
       // cache it as well (mutex is already locked)
-      sTileCache.insert( url, new QImage( image ) );
-
-      return true;
+      // Check for null because it could be a redirect (see: https://issues.qgis.org/issues/16427 )
+      if ( ! image.isNull( ) )
+      {
+        sTileCache.insert( url, new QImage( image ) );
+        return true;
+      }
     }
   }
   return false;