Skip to content

Commit

Permalink
[FEATURE] Drop processing 'Select by Attribute Sum' algorithm
Browse files Browse the repository at this point in the history
Tagged as feature to be included in release notes.

Because:

- The use case for this algorithm is very unclear for users - the name
does not describe what the algorithm does, and there's no help
documentation available for the algorithm either. Given this I suspect
that the algorithm is not being put into use.

- The algorithm needs enhancement to be more useful. There's no logic
in place which dictates how neighbouring features are chosen to
dissolve into the selected feature (it's effectively random - you're
just as likely to get a huge narrow polygon stretching across a map as
you are a nice compact cluster). To be more useful the algorithm would
need logic to either minimise the area of the dissolved feature, or
minimise the total number of dissolved features, or ... ?
  • Loading branch information
nyalldawson committed Sep 5, 2017
1 parent 72462ae commit d08398f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 112 deletions.
3 changes: 0 additions & 3 deletions python/plugins/processing/algs/help/qgis.yaml
Expand Up @@ -525,9 +525,6 @@ qgis:saveselectedfeatures: >
qgis:selectbyattribute: >
This algorithm creates a selection in a vector layer. The criteria for selected features is defined based on the values of an attribute from the input layer.

qgis:selectbyattributesum:


qgis:selectbyexpression: >
This algorithm creates a selection in a vector layer. The criteria for selecting features is based on a QGIS expression.

Expand Down
2 changes: 0 additions & 2 deletions python/plugins/processing/algs/qgis/QGISAlgorithmProvider.py
Expand Up @@ -174,7 +174,6 @@
# from .ExtractByLocation import ExtractByLocation
# from .SelectByLocation import SelectByLocation
# from .SpatialJoin import SpatialJoin
# from .SelectByAttributeSum import SelectByAttributeSum

pluginPath = os.path.normpath(os.path.join(
os.path.split(os.path.dirname(__file__))[0], os.pardir))
Expand All @@ -192,7 +191,6 @@ def getAlgs(self):
# SelectByLocation(),
# ExtractByLocation(),
# SpatialJoin(),
# SelectByAttributeSum()
# ]
algs = [AddTableField(),
Aggregate(),
Expand Down
107 changes: 0 additions & 107 deletions python/plugins/processing/algs/qgis/SelectByAttributeSum.py

This file was deleted.

0 comments on commit d08398f

Please sign in to comment.