Fix clazy warnings

qgis · Feb 12, 2021 · cf43c60 · cf43c60
1 parent 0f49cb9
commit cf43c60
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/python/core/auto_generated/qgsrelation.sip.in b/python/core/auto_generated/qgsrelation.sip.in
@@ -321,7 +321,7 @@ Will be called internally whenever a member is changed.
 .. versionadded:: 3.6
 %End
 
-    void setPolymorphicRelationId( const QString polymorphicRelationId );
+    void setPolymorphicRelationId( const QString &polymorphicRelationId );
 %Docstring
 Sets the parent polymorphic relation id.
 

diff --git a/src/core/qgsrelation.cpp b/src/core/qgsrelation.cpp
@@ -317,7 +317,7 @@ QList<QgsRelation::FieldPair> QgsRelation::fieldPairs() const
 QgsAttributeList QgsRelation::referencedFields() const
 {
   QgsAttributeList attrs;
-
+  attrs.reserve( d->mFieldPairs.size() );
   for ( const FieldPair &pair : qgis::as_const( d->mFieldPairs ) )
   {
     attrs << d->mReferencedLayer->fields().lookupField( pair.second );
@@ -421,7 +421,7 @@ void QgsRelation::updateRelationStatus()
   }
 }
 
-void QgsRelation::setPolymorphicRelationId( const QString polymorphicRelationId )
+void QgsRelation::setPolymorphicRelationId( const QString &polymorphicRelationId )
 {
   d.detach();
   d->mPolymorphicRelationId = polymorphicRelationId;

diff --git a/src/core/qgsrelation.h b/src/core/qgsrelation.h
@@ -398,7 +398,7 @@ class CORE_EXPORT QgsRelation
      * Sets the parent polymorphic relation id.
      * \since QGIS 3.18
      */
-    void setPolymorphicRelationId( const QString polymorphicRelationId );
+    void setPolymorphicRelationId( const QString &polymorphicRelationId );
 
     /**
      * Returns the parent polymorphic relation id. If the relation is a normal relation, a null string is returned.