Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Backport #9440 on release-3_6 (#9443)
* [plugin manager] Call abort before disconnecting finished

* alternative
  • Loading branch information
backporting[bot] authored and nirvn committed Mar 9, 2019
1 parent e4c85cd commit cf1f0d8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions python/pyplugin_installer/installer_data.py
Expand Up @@ -339,7 +339,7 @@ def requestFetching(self, key, url=None, redirectionCounter=0):
self.mRepositories[key]["xmlData"].setProperty('reposName', key)
self.mRepositories[key]["xmlData"].setProperty('redirectionCounter', redirectionCounter)
self.mRepositories[key]["xmlData"].downloadProgress.connect(self.mRepositories[key]["Relay"].dataReadProgress)
self.mRepositories[key]["xmlData"].finished.connect(self.xmlDownloaded)
self.mRepositories[key]["xmlDataFinished"] = self.mRepositories[key]["xmlData"].finished.connect(self.xmlDownloaded)

# ----------------------------------------- #
def fetchingInProgress(self):
Expand All @@ -353,7 +353,7 @@ def fetchingInProgress(self):
def killConnection(self, key):
""" kill the fetching on demand """
if self.mRepositories[key]["state"] == 1 and self.mRepositories[key]["xmlData"] and self.mRepositories[key]["xmlData"].isRunning():
self.mRepositories[key]["xmlData"].finished.disconnect()
self.mRepositories[key]["xmlData"].finished.disconnect(self.mRepositories[key]["xmlDataFinished"])
self.mRepositories[key]["xmlData"].abort()

# ----------------------------------------- #
Expand Down

0 comments on commit cf1f0d8

Please sign in to comment.