Fix layout legend layer title not immediately updating

nyalldawson · nyalldawson · commit cec7e48e9a0b · 2023-04-04T18:56:45.000+10:00
Fixes #52261
diff --git a/python/core/auto_generated/layout/qgslayoutitemlegend.sip.in b/python/core/auto_generated/layout/qgslayoutitemlegend.sip.in
@@ -593,6 +593,8 @@ Returns the legend's renderer settings object.
 
     virtual void refresh();
 
+    virtual void invalidateCache();
+
     virtual void refreshDataDefinedProperty( QgsLayoutObject::DataDefinedProperty property = QgsLayoutObject::AllProperties );
 
 
diff --git a/src/core/layout/qgslayoutitemlegend.cpp b/src/core/layout/qgslayoutitemlegend.cpp
@@ -194,6 +194,12 @@ void QgsLayoutItemLegend::refresh()
   onAtlasFeature();
 }
 
+void QgsLayoutItemLegend::invalidateCache()
+{
+  clearLegendCachedData();
+  QgsLayoutItem::invalidateCache();
+}
+
 void QgsLayoutItemLegend::draw( QgsLayoutItemRenderContext &context )
 {
   QPainter *painter = context.renderContext().painter();
diff --git a/src/core/layout/qgslayoutitemlegend.h b/src/core/layout/qgslayoutitemlegend.h
@@ -560,6 +560,7 @@ class CORE_EXPORT QgsLayoutItemLegend : public QgsLayoutItem
   public slots:
 
     void refresh() override;
+    void invalidateCache() override;
     void refreshDataDefinedProperty( QgsLayoutObject::DataDefinedProperty property = QgsLayoutObject::AllProperties ) override;
 
   protected:
diff --git a/src/gui/layout/qgslayoutlegendwidget.cpp b/src/gui/layout/qgslayoutlegendwidget.cpp
@@ -1695,6 +1695,7 @@ void QgsLayoutLegendNodeWidget::labelChanged()
   }
 
   mLegend->adjustBoxSize();
+  mLegend->invalidateCache();
   mLegend->update();
   mLegend->endCommand();
 }

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,12 @@ void QgsLayoutItemLegend::refresh()`
`194`	`194`	`onAtlasFeature();`
`195`	`195`	`}`
`196`	`196`
	`197`	`+void QgsLayoutItemLegend::invalidateCache()`
	`198`	`+{`
	`199`	`+ clearLegendCachedData();`
	`200`	`+ QgsLayoutItem::invalidateCache();`
	`201`	`+}`
	`202`	`+`
`197`	`203`	`void QgsLayoutItemLegend::draw( QgsLayoutItemRenderContext &context )`
`198`	`204`	`{`
`199`	`205`	`QPainter *painter = context.renderContext().painter();`
Original file line number	Diff line number	Diff line change
`@@ -1695,6 +1695,7 @@ void QgsLayoutLegendNodeWidget::labelChanged()`
`1695`	`1695`	`}`
`1696`	`1696`
`1697`	`1697`	`mLegend->adjustBoxSize();`
	`1698`	`+ mLegend->invalidateCache();`
`1698`	`1699`	`mLegend->update();`
`1699`	`1700`	`mLegend->endCommand();`
`1700`	`1701`	`}`