[mesh] Add an angry comment, fix memory leak

nyalldawson · nyalldawson · commit ce5841c847ea · 2019-12-10T12:39:53.000+10:00
diff --git a/src/analysis/mesh/qgsmeshcalcutils.cpp b/src/analysis/mesh/qgsmeshcalcutils.cpp
@@ -24,6 +24,7 @@
 #include "qgstriangularmesh.h"
 #include "qgsmapsettings.h"
 #include "qgsmeshlayerutils.h"
+#include "qgsmeshlayerrenderer.h"
 
 const double D_TRUE = 1.0;
 const double D_FALSE = 0.0;
@@ -696,6 +697,9 @@ void QgsMeshCalcUtils::updateMesh() const
 {
   if ( ! mMeshLayer->nativeMesh() )
   {
+    // THIS code is very confusing -- someone please add some explanation as to why a map renderer is created here! (Or better,
+    // add explicit members to do whatever it is that's actually wanted here, instead of creating the map renderer)
+
     // we do not care about triangles,
     // we just want transformed coordinates
     // of the native mesh. So create
@@ -705,7 +709,8 @@ void QgsMeshCalcUtils::updateMesh() const
     mapSettings.setDestinationCrs( mMeshLayer->crs() );
     mapSettings.setOutputDpi( 96 );
     QgsRenderContext context = QgsRenderContext::fromMapSettings( mapSettings );
-    mMeshLayer->createMapRenderer( context );
+
+    delete mMeshLayer->createMapRenderer( context );
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`#include "qgstriangularmesh.h"`
`25`	`25`	`#include "qgsmapsettings.h"`
`26`	`26`	`#include "qgsmeshlayerutils.h"`
	`27`	`+#include "qgsmeshlayerrenderer.h"`
`27`	`28`
`28`	`29`	`const double D_TRUE = 1.0;`
`29`	`30`	`const double D_FALSE = 0.0;`
`@@ -696,6 +697,9 @@ void QgsMeshCalcUtils::updateMesh() const`
`696`	`697`	`{`
`697`	`698`	`if ( ! mMeshLayer->nativeMesh() )`
`698`	`699`	`{`
	`700`	`+ // THIS code is very confusing -- someone please add some explanation as to why a map renderer is created here! (Or better,`
	`701`	`+ // add explicit members to do whatever it is that's actually wanted here, instead of creating the map renderer)`
	`702`	`+`
`699`	`703`	`// we do not care about triangles,`
`700`	`704`	`// we just want transformed coordinates`
`701`	`705`	`// of the native mesh. So create`
`@@ -705,7 +709,8 @@ void QgsMeshCalcUtils::updateMesh() const`
`705`	`709`	`mapSettings.setDestinationCrs( mMeshLayer->crs() );`
`706`	`710`	`mapSettings.setOutputDpi( 96 );`
`707`	`711`	`QgsRenderContext context = QgsRenderContext::fromMapSettings( mapSettings );`
`708`		`- mMeshLayer->createMapRenderer( context );`
	`712`	`+`
	`713`	`+ delete mMeshLayer->createMapRenderer( context );`
`709`	`714`	`}`
`710`	`715`	`}`
`711`	`716`