Modernize connections to actions

m-kuhn · m-kuhn · commit cd83c3c6d14b · 2017-07-28T11:45:17.000+02:00
Use function references rather than SLOTs
diff --git a/src/gui/attributetable/qgsdualview.cpp b/src/gui/attributetable/qgsdualview.cpp
@@ -489,13 +489,13 @@ void QgsDualView::viewWillShowContextMenu( QMenu *menu, const QModelIndex &atInd
     for ( actionIt = registeredActions.begin(); actionIt != registeredActions.end(); ++actionIt )
     {
       QgsAttributeTableMapLayerAction *a = new QgsAttributeTableMapLayerAction( ( *actionIt )->text(), this, ( *actionIt ), sourceIndex );
-      menu->addAction( ( *actionIt )->text(), a, SLOT( execute() ) );
+      menu->addAction( ( *actionIt )->text(), a, &QgsAttributeTableMapLayerAction::execute );
     }
   }
 
   menu->addSeparator();
   QgsAttributeTableAction *a = new QgsAttributeTableAction( tr( "Open form" ), this, QString(), sourceIndex );
-  menu->addAction( tr( "Open form" ), a, SLOT( featureForm() ) );
+  menu->addAction( tr( "Open form" ), a, &QgsAttributeTableAction::featureForm );
 }
 
 void QgsDualView::showViewHeaderMenu( QPoint point )

Original file line number	Diff line number	Diff line change
`@@ -489,13 +489,13 @@ void QgsDualView::viewWillShowContextMenu( QMenu *menu, const QModelIndex &atInd`
`489`	`489`	`for ( actionIt = registeredActions.begin(); actionIt != registeredActions.end(); ++actionIt )`
`490`	`490`	`{`
`491`	`491`	`QgsAttributeTableMapLayerAction a = new QgsAttributeTableMapLayerAction( ( actionIt )->text(), this, ( *actionIt ), sourceIndex );`
`492`		`- menu->addAction( ( *actionIt )->text(), a, SLOT( execute() ) );`
	`492`	`+ menu->addAction( ( *actionIt )->text(), a, &QgsAttributeTableMapLayerAction::execute );`
`493`	`493`	`}`
`494`	`494`	`}`
`495`	`495`
`496`	`496`	`menu->addSeparator();`
`497`	`497`	`QgsAttributeTableAction *a = new QgsAttributeTableAction( tr( "Open form" ), this, QString(), sourceIndex );`
`498`		`- menu->addAction( tr( "Open form" ), a, SLOT( featureForm() ) );`
	`498`	`+ menu->addAction( tr( "Open form" ), a, &QgsAttributeTableAction::featureForm );`
`499`	`499`	`}`
`500`	`500`
`501`	`501`	`void QgsDualView::showViewHeaderMenu( QPoint point )`