fix crash

jef · jef · commit cd04da4ad571 · 2010-03-01T15:53:12.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@12987 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgsidentifyresults.cpp b/src/app/qgsidentifyresults.cpp
@@ -47,12 +47,18 @@ static void _runPythonString( const QString &expr )
   QgisApp::instance()->runPythonString( expr );
 }
 
-void QgsFeatureAction::execute()
+QgsFeatureAction::QgsFeatureAction( const QString &name, QgsIdentifyResults *results, QgsVectorLayer *vl, int action, QTreeWidgetItem *featItem )
+    : QAction( name, results )
+    , mLayer( vl )
+    , mAction( action )
 {
-  int idx;
   QList< QPair<QString, QString> > attributes;
-  mResults->retrieveAttributes( mFeatItem, attributes, idx );
-  mLayer->actions()->doAction( mAction, attributes, idx, _runPythonString );
+  results->retrieveAttributes( featItem, mAttributes, mIdx );
+}
+
+void QgsFeatureAction::execute()
+{
+  mLayer->actions()->doAction( mAction, mAttributes, mIdx, _runPythonString );
 }
 
 class QgsIdentifyResultsDock : public QDockWidget
diff --git a/src/app/qgsidentifyresults.h b/src/app/qgsidentifyresults.h
@@ -137,18 +137,16 @@ class QgsFeatureAction : public QAction
     Q_OBJECT
 
   public:
-    QgsFeatureAction( const QString &name, QgsIdentifyResults *results, QgsVectorLayer *vl, int action, QTreeWidgetItem *featItem ) :
-        QAction( name, results ), mResults( results ), mLayer( vl ), mAction( action ), mFeatItem( featItem )
-    {}
+    QgsFeatureAction( const QString &name, QgsIdentifyResults *results, QgsVectorLayer *vl, int action, QTreeWidgetItem *featItem );
 
   public slots:
     void execute();
 
   private:
-    QgsIdentifyResults *mResults;
     QgsVectorLayer *mLayer;
     int mAction;
-    QTreeWidgetItem *mFeatItem;
+    int mIdx;
+    QList< QPair<QString, QString> > mAttributes;
 };
 
 #endif
