Remove some unnecessary initializers

nyalldawson · nyalldawson · commit ccf0dc8fa3e5 · 2017-09-11T17:11:50.000+10:00
From clang-tidy readability-redundant-member-init
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -607,7 +607,6 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
   : QMainWindow( parent, fl )
   , mSplash( splash )
   , mShowProjectionTab( false )
-  , mProjectLastModified()
 {
   if ( sInstance )
   {
@@ -1219,7 +1218,6 @@ QgisApp::QgisApp()
   , mPrevScreenModeMaximized( false )
   , mSaveRollbackInProgress( false )
   , mTrustedMacros( false )
-  , mProjectLastModified()
   , mProjOpen( 0 )
 {
   sInstance = this;
diff --git a/src/app/qgsclipboard.cpp b/src/app/qgsclipboard.cpp
@@ -41,8 +41,6 @@
 
 QgsClipboard::QgsClipboard()
   : QObject()
-  , mFeatureClipboard()
-  , mFeatureFields()
   , mUseSystemClipboard( false )
 {
   connect( QApplication::clipboard(), &QClipboard::dataChanged, this, &QgsClipboard::systemClipboardChanged );
diff --git a/src/app/qgsprojectproperties.cpp b/src/app/qgsprojectproperties.cpp
@@ -71,9 +71,7 @@ const char *QgsProjectProperties::GEO_NONE_DESC = QT_TRANSLATE_NOOP( "QgsOptions
 QgsProjectProperties::QgsProjectProperties( QgsMapCanvas *mapCanvas, QWidget *parent, Qt::WindowFlags fl )
   : QgsOptionsDialogBase( QStringLiteral( "ProjectProperties" ), parent, fl )
   , mMapCanvas( mapCanvas )
-  , mEllipsoidList()
   , mEllipsoidIndex( 0 )
-
 {
   setupUi( this );
   connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsProjectProperties::showHelp );
diff --git a/src/core/qgsmapsettings.cpp b/src/core/qgsmapsettings.cpp
@@ -34,10 +34,8 @@ Q_GUI_EXPORT extern int qt_defaultDpiX();
 QgsMapSettings::QgsMapSettings()
   : mDpi( qt_defaultDpiX() ) // DPI that will be used by default for QImage instances
   , mSize( QSize( 0, 0 ) )
-  , mExtent()
   , mRotation( 0.0 )
   , mMagnificationFactor( 1.0 )
-  , mDestCRS()
   , mDatumTransformStore( mDestCRS )
   , mBackgroundColor( Qt::white )
   , mSelectionColor( Qt::yellow )
@@ -46,7 +44,6 @@ QgsMapSettings::QgsMapSettings()
   , mSegmentationTolerance( M_PI_2 / 90 )
   , mSegmentationToleranceType( QgsAbstractGeometry::MaximumAngle )
   , mValid( false )
-  , mVisibleExtent()
   , mMapUnitsPerPixel( 1 )
   , mScale( 1 )
 {
diff --git a/src/gui/attributetable/qgsdualview.cpp b/src/gui/attributetable/qgsdualview.cpp
@@ -41,8 +41,6 @@
 
 QgsDualView::QgsDualView( QWidget *parent )
   : QStackedWidget( parent )
-  , mEditorContext()
-
 {
   setupUi( this );
 

Original file line number	Diff line number	Diff line change
`@@ -607,7 +607,6 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh`
`607`	`607`	`: QMainWindow( parent, fl )`
`608`	`608`	`, mSplash( splash )`
`609`	`609`	`, mShowProjectionTab( false )`
`610`		`- , mProjectLastModified()`
`611`	`610`	`{`
`612`	`611`	`if ( sInstance )`
`613`	`612`	`{`
`@@ -1219,7 +1218,6 @@ QgisApp::QgisApp()`
`1219`	`1218`	`, mPrevScreenModeMaximized( false )`
`1220`	`1219`	`, mSaveRollbackInProgress( false )`
`1221`	`1220`	`, mTrustedMacros( false )`
`1222`		`- , mProjectLastModified()`
`1223`	`1221`	`, mProjOpen( 0 )`
`1224`	`1222`	`{`
`1225`	`1223`	`sInstance = this;`
Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,6 @@`
`41`	`41`
`42`	`42`	`QgsClipboard::QgsClipboard()`
`43`	`43`	`: QObject()`
`44`		`- , mFeatureClipboard()`
`45`		`- , mFeatureFields()`
`46`	`44`	`, mUseSystemClipboard( false )`
`47`	`45`	`{`
`48`	`46`	`connect( QApplication::clipboard(), &QClipboard::dataChanged, this, &QgsClipboard::systemClipboardChanged );`