Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit cbf5569

Browse files
committedAug 8, 2018
Fix the Access control in the WMS groups
1 parent 5e1184a commit cbf5569

File tree

2 files changed

+232
-16
lines changed

2 files changed

+232
-16
lines changed
 

‎src/server/services/wms/qgswmsrenderer.cpp

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -330,18 +330,16 @@ namespace QgsWms
330330
bool updateMapExtent = mWmsParameters.bbox().isEmpty();
331331
Q_FOREACH ( QgsMapLayer *layer, layers )
332332
{
333+
checkLayerReadPermissions( layer );
334+
333335
Q_FOREACH ( QgsWmsParametersLayer param, params )
334336
{
335337
if ( param.mNickname == layerNickname( *layer ) )
336338
{
337-
checkLayerReadPermissions( layer );
338-
339339
setLayerOpacity( layer, param.mOpacity );
340340

341341
setLayerFilter( layer, param.mFilter );
342342

343-
setLayerAccessControlFilter( layer );
344-
345343
setLayerSelection( layer, param.mSelection );
346344

347345
if ( updateMapExtent )
@@ -350,6 +348,8 @@ namespace QgsWms
350348
break;
351349
}
352350
}
351+
352+
setLayerAccessControlFilter( layer );
353353
}
354354

355355
// add highlight layers above others
@@ -679,18 +679,16 @@ namespace QgsWms
679679
bool updateMapExtent = mWmsParameters.bbox().isEmpty();
680680
Q_FOREACH ( QgsMapLayer *layer, layers )
681681
{
682+
checkLayerReadPermissions( layer );
683+
682684
Q_FOREACH ( QgsWmsParametersLayer param, params )
683685
{
684686
if ( param.mNickname == layerNickname( *layer ) )
685687
{
686-
checkLayerReadPermissions( layer );
687-
688688
setLayerOpacity( layer, param.mOpacity );
689689

690690
setLayerFilter( layer, param.mFilter );
691691

692-
setLayerAccessControlFilter( layer );
693-
694692
setLayerSelection( layer, param.mSelection );
695693

696694
if ( updateMapExtent )
@@ -699,6 +697,8 @@ namespace QgsWms
699697
break;
700698
}
701699
}
700+
701+
setLayerAccessControlFilter( layer );
702702
}
703703

704704
// add highlight layers above others
@@ -781,21 +781,23 @@ namespace QgsWms
781781
continue;
782782
if ( !wfsLayerIds.contains( layer->id() ) )
783783
continue;
784+
785+
checkLayerReadPermissions( layer );
786+
784787
Q_FOREACH ( QgsWmsParametersLayer param, params )
785788
{
786789
if ( param.mNickname == layerNickname( *layer ) )
787790
{
788-
checkLayerReadPermissions( layer );
789-
790791
setLayerOpacity( layer, param.mOpacity );
791792

792793
setLayerFilter( layer, param.mFilter );
793794

794-
setLayerAccessControlFilter( layer );
795-
796795
break;
797796
}
798797
}
798+
799+
setLayerAccessControlFilter( layer );
800+
799801
// cast for dxf layers
800802
QgsVectorLayer *vlayer = static_cast<QgsVectorLayer *>( layer );
801803

@@ -951,19 +953,19 @@ namespace QgsWms
951953

952954
Q_FOREACH ( QgsMapLayer *layer, layers )
953955
{
956+
checkLayerReadPermissions( layer );
957+
954958
Q_FOREACH ( QgsWmsParametersLayer param, params )
955959
{
956960
if ( param.mNickname == layerNickname( *layer ) )
957961
{
958-
checkLayerReadPermissions( layer );
959-
960962
setLayerFilter( layer, param.mFilter );
961963

962-
setLayerAccessControlFilter( layer );
963-
964964
break;
965965
}
966966
}
967+
968+
setLayerAccessControlFilter( layer );
967969
}
968970

969971
// add layers to map settings (revert order for the rendering)

0 commit comments

Comments
 (0)
Please sign in to comment.