qgs3daxis: Fix camera conf by taking into account terrain offset

ptitjano · github-actions[bot] · commit cbabdac2fb8f · 2023-03-20T23:47:03.000Z
This was found by Stefanos Natsis.
diff --git a/src/3d/qgs3daxis.cpp b/src/3d/qgs3daxis.cpp
@@ -745,7 +745,7 @@ void Qgs3DAxis::onCameraViewChange( float pitch, float yaw )
       QgsDebugMsgLevel( "Unable to obtain elevation from terrain", 2 );
 
   }
-  pos.set( pos.x(), elevation, pos.z() );
+  pos.set( pos.x(), elevation + mMapSettings->terrainElevationOffset(), pos.z() );
 
   mCameraController->setLookingAtPoint( pos, ( mCameraController->camera()->position() - pos.toVector3D() ).length(),
                                         pitch, yaw );

Original file line number	Diff line number	Diff line change
`@@ -745,7 +745,7 @@ void Qgs3DAxis::onCameraViewChange( float pitch, float yaw )`
`745`	`745`	`QgsDebugMsgLevel( "Unable to obtain elevation from terrain", 2 );`
`746`	`746`
`747`	`747`	`}`
`748`		`- pos.set( pos.x(), elevation, pos.z() );`
	`748`	`+ pos.set( pos.x(), elevation + mMapSettings->terrainElevationOffset(), pos.z() );`
`749`	`749`
`750`	`750`	`mCameraController->setLookingAtPoint( pos, ( mCameraController->camera()->position() - pos.toVector3D() ).length(),`
`751`	`751`	`pitch, yaw );`