Revert "Remove virtual method from class which shouldn't be subclassed"

This reverts commit 858129d. I remember now... that was added to avoid a totally nonsense and otherwise unfixable crash in the sip bindings...
qgis · Apr 24, 2017 · cb68c98 · cb68c98
1 parent 7b3859b
commit cb68c98
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/python/core/qgsproperty.sip b/python/core/qgsproperty.sip
@@ -80,6 +80,8 @@ class QgsProperty
     };
 
     QgsProperty();
+    virtual ~QgsProperty();
+
     static QgsProperty fromExpression( const QString& expression, bool isActive = true );
     static QgsProperty fromField( const QString& fieldName, bool isActive = true );
     static QgsProperty fromValue( const QVariant& value, bool isActive = true );

diff --git a/src/core/qgsproperty.h b/src/core/qgsproperty.h
@@ -201,6 +201,8 @@ class CORE_EXPORT QgsProperty
      */
     QgsProperty();
 
+    virtual ~QgsProperty() = default;
+
     /**
      * Returns a new ExpressionBasedProperty created from the specified expression.
      */