iterate through features with iterator

qgis · Oct 25, 2018 · cb19b34 · cb19b34
1 parent 5bcff46
commit cb19b34
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/app/qgsmaptoolfeatureaction.cpp b/src/app/qgsmaptoolfeatureaction.cpp
@@ -138,17 +138,17 @@ bool QgsMapToolFeatureAction::doAction( QgsVectorLayer *layer, int x, int y )
     else
     {
       QMenu *featureMenu = new QMenu();
-      for ( int idx = 0; idx < features.count(); idx++ )
+      for ( const QgsFeature &feature : features )
       {
-        QAction *featureAction = featureMenu->addAction( FID_TO_STRING( features.at( idx ).id() ) );
-        connect( featureAction, &QAction::triggered, this, [ = ] { doActionForFeature( layer, features.at( idx ), point );} );
+        QAction *featureAction = featureMenu->addAction( FID_TO_STRING( feature.id() ) );
+        connect( featureAction, &QAction::triggered, this, [ = ] { doActionForFeature( layer, feature, point );} );
       }
       QAction *allFeatureAction = featureMenu->addAction( tr( "All Features" ) );
       connect( allFeatureAction, &QAction::triggered, this, [ = ]
       {
-        for ( int idx = 0; idx < features.count(); idx++ )
+        for ( const QgsFeature &feature : features )
         {
-          doActionForFeature( layer, features.at( idx ), point );
+          doActionForFeature( layer, feature, point );
         }
       } );
       featureMenu->exec( position );