Skip to content

Commit

Permalink
Fix redundant angle methods for QgsGradientFillSymbolLayerV2
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Jan 15, 2015
1 parent 0e35495 commit ca4a60a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions python/core/symbology-ng/qgsfillsymbollayerv2.sip
Expand Up @@ -196,10 +196,6 @@ class QgsGradientFillSymbolLayerV2 : QgsFillSymbolLayerV2
void setReferencePoint2IsCentroid( bool isCentroid );
bool referencePoint2IsCentroid() const;

/**Rotation angle for gradient fill. Can be used to rotate a gradient around its centre point*/
void setAngle( double angle );
double angle() const;

/**Offset for gradient fill*/
void setOffset( QPointF offset );
QPointF offset() const;
Expand Down
1 change: 0 additions & 1 deletion src/core/symbology-ng/qgsfillsymbollayerv2.cpp
Expand Up @@ -428,7 +428,6 @@ QgsGradientFillSymbolLayerV2::QgsGradientFillSymbolLayerV2( QColor color, QColor
, mReferencePoint1IsCentroid( false )
, mReferencePoint2( QPointF( 0.5, 1 ) )
, mReferencePoint2IsCentroid( false )
, mAngle( 0 )
, mOffsetUnit( QgsSymbolV2::MM )
{
mColor = color;
Expand Down
5 changes: 0 additions & 5 deletions src/core/symbology-ng/qgsfillsymbollayerv2.h
Expand Up @@ -246,10 +246,6 @@ class CORE_EXPORT QgsGradientFillSymbolLayerV2 : public QgsFillSymbolLayerV2
void setReferencePoint2IsCentroid( bool isCentroid ) { mReferencePoint2IsCentroid = isCentroid; }
bool referencePoint2IsCentroid() const { return mReferencePoint2IsCentroid; }

/**Rotation angle for gradient fill. Can be used to rotate a gradient around its centre point*/
void setAngle( double angle ) { mAngle = angle; }

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn Jan 15, 2015

Member

Does that break the API? Could it be forwarded to the redundant method instead?

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson Jan 15, 2015

Author Collaborator

@m-kuhn shouldn't be - it was an exact copy of the base class' implementation.

double angle() const { return mAngle; }

/**Offset for gradient fill*/
void setOffset( QPointF offset ) { mOffset = offset; }
QPointF offset() const { return mOffset; }
Expand Down Expand Up @@ -282,7 +278,6 @@ class CORE_EXPORT QgsGradientFillSymbolLayerV2 : public QgsFillSymbolLayerV2
bool mReferencePoint1IsCentroid;
QPointF mReferencePoint2;
bool mReferencePoint2IsCentroid;
double mAngle;

QPointF mOffset;
QgsSymbolV2::OutputUnit mOffsetUnit;
Expand Down

0 comments on commit ca4a60a

Please sign in to comment.