Fix broken QgsFeatureStore::setFields method

Was setting fields only on temporary copies of the features, not the stored features themselves (cherry-picked from 910cb01)
qgis · Sep 16, 2015 · c8d625a · c8d625a
1 parent 8538be6
commit c8d625a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/python/core/qgsfeaturestore.sip b/python/core/qgsfeaturestore.sip
@@ -19,7 +19,7 @@ class QgsFeatureStore
     /** Get fields list */
     QgsFields& fields();
 
-    /** Set fields. Resets feauters fields to pointer to new internal fields. */
+    /** Set fields. Resets feature's fields to pointer to new internal fields. */
     void setFields( const QgsFields & fields );
 
     /** Get crs */

diff --git a/src/core/qgsfeaturestore.cpp b/src/core/qgsfeaturestore.cpp
@@ -40,9 +40,10 @@ QgsFeatureStore::~QgsFeatureStore()
 void QgsFeatureStore::setFields( const QgsFields & fields )
 {
   mFields = fields;
-  foreach ( QgsFeature feature, mFeatures )
+  QgsFeatureList::iterator it = mFeatures.begin();
+  for ( ; it != mFeatures.end(); ++it )
   {
-    feature.setFields( &mFields );
+    ( *it ).setFields( &mFields );
   }
 }
 

diff --git a/src/core/qgsfeaturestore.h b/src/core/qgsfeaturestore.h
@@ -45,7 +45,7 @@ class CORE_EXPORT QgsFeatureStore
     /** Get fields list */
     QgsFields& fields() { return mFields; }
 
-    /** Set fields. Resets feauters fields to pointer to new internal fields. */
+    /** Set fields. Resets feature's fields to pointer to new internal fields. */
     void setFields( const QgsFields & fields );
 
     /** Get crs */