Identify on mouse move, no mouse click

Adds an option to allow for identify on mouse move without clicking on the canvas. This option behaves almost like the default identify option, the only difference is that the used doesn't need to click to trigger the identify action. A 300ms timer takes care of triggering the actual identify to avoid performance issues when moving the mouse.
qgis · Nov 8, 2022 · c7e62d6 · c7e62d6
1 parent 25a69f2
commit c7e62d6
Show file tree

Hide file tree

Showing 7 changed files with 71 additions and 2 deletions.
diff --git a/images/images.qrc b/images/images.qrc
@@ -966,6 +966,7 @@
         <file>themes/default/mIconFonts.svg</file>
         <file>themes/default/mActionNewFileGeodatabase.svg</file>
         <file>themes/default/mIconBrowserRelations.svg</file>
+        <file>themes/default/mActionIdentifyByMouseMove.svg</file>
         <file>themes/default/gpsicons/mIconGpsConnect.svg</file>
         <file>themes/default/gpsicons/mIconGpsDisconnect.svg</file>
         <file>themes/default/gpsicons/mActionRecenter.svg</file>

diff --git a/images/themes/default/mActionIdentifyByMouseMove.svg b/images/themes/default/mActionIdentifyByMouseMove.svg
diff --git a/src/app/qgsidentifyresultsdialog.cpp b/src/app/qgsidentifyresultsdialog.cpp
@@ -466,11 +466,12 @@ void QgsIdentifyResultsDialog::initSelectionModes()
   mSelectModeButton = new QToolButton( mIdentifyToolbar );
   mSelectModeButton->setPopupMode( QToolButton::MenuButtonPopup );
   QList<QAction *> selectActions;
-  selectActions << mActionSelectFeatures << mActionSelectPolygon
+  selectActions << mActionSelectFeatures << mActionSelectFeaturesOnMouseMove << mActionSelectPolygon
                 << mActionSelectFreehand << mActionSelectRadius;
 
   QActionGroup *group = new QActionGroup( this );
   group->addAction( mActionSelectFeatures );
+  group->addAction( mActionSelectFeaturesOnMouseMove );
   group->addAction( mActionSelectPolygon );
   group->addAction( mActionSelectFreehand );
   group->addAction( mActionSelectRadius );
@@ -481,6 +482,7 @@ void QgsIdentifyResultsDialog::initSelectionModes()
   mIdentifyToolbar->addWidget( mSelectModeButton );
 
   connect( mActionSelectFeatures, &QAction::triggered, this, &QgsIdentifyResultsDialog::setSelectionMode );
+  connect( mActionSelectFeaturesOnMouseMove, &QAction::triggered, this, &QgsIdentifyResultsDialog::setSelectionMode );
   connect( mActionSelectPolygon, &QAction::triggered, this, &QgsIdentifyResultsDialog::setSelectionMode );
   connect( mActionSelectFreehand, &QAction::triggered, this, &QgsIdentifyResultsDialog::setSelectionMode );
   connect( mActionSelectRadius, &QAction::triggered, this, &QgsIdentifyResultsDialog::setSelectionMode );
@@ -2543,6 +2545,11 @@ void QgsIdentifyResultsDialog::setSelectionMode()
     mSelectModeButton->setDefaultAction( mActionSelectPolygon );
     mSelectionMode = QgsMapToolSelectionHandler::SelectPolygon;
   }
+  else if ( obj == mActionSelectFeaturesOnMouseMove )
+  {
+    mSelectModeButton->setDefaultAction( mActionSelectFeaturesOnMouseMove );
+    mSelectionMode = QgsMapToolSelectionHandler::SelectOnMouseMove;
+  }
   else if ( obj == mActionSelectFreehand )
   {
     mSelectModeButton->setDefaultAction( mActionSelectFreehand );

diff --git a/src/app/qgsmaptoolselect.cpp b/src/app/qgsmaptoolselect.cpp
@@ -133,6 +133,7 @@ QgsMapTool::Flags QgsMapToolSelect::flags() const
       break;
 
     case QgsMapToolSelectionHandler::SelectSimple:
+    case QgsMapToolSelectionHandler::SelectOnMouseMove:
     case QgsMapToolSelectionHandler::SelectFreehand:
     case QgsMapToolSelectionHandler::SelectRadius:
       return QgsMapTool::flags() | QgsMapTool::ShowContextMenu;

diff --git a/src/app/qgsmaptoolselectionhandler.cpp b/src/app/qgsmaptoolselectionhandler.cpp
@@ -117,6 +117,7 @@ void QgsMapToolSelectionHandler::canvasReleaseEvent( QgsMapMouseEvent *e )
   switch ( mSelectionMode )
   {
     case QgsMapToolSelectionHandler::SelectSimple:
+    case QgsMapToolSelectionHandler::SelectOnMouseMove:
       selectFeaturesReleaseEvent( e );
       break;
     case QgsMapToolSelectionHandler::SelectPolygon:
@@ -135,6 +136,7 @@ void QgsMapToolSelectionHandler::canvasMoveEvent( QgsMapMouseEvent *e )
 {
   switch ( mSelectionMode )
   {
+    case QgsMapToolSelectionHandler::SelectOnMouseMove:
     case QgsMapToolSelectionHandler::SelectSimple:
       selectFeaturesMoveEvent( e );
       break;
@@ -154,6 +156,7 @@ void QgsMapToolSelectionHandler::canvasPressEvent( QgsMapMouseEvent *e )
 {
   switch ( mSelectionMode )
   {
+    case QgsMapToolSelectionHandler::SelectOnMouseMove:
     case QgsMapToolSelectionHandler::SelectSimple:
       selectFeaturesPressEvent( e );
       break;
@@ -192,6 +195,18 @@ void QgsMapToolSelectionHandler::selectFeaturesPressEvent( QgsMapMouseEvent *e )
 
 void QgsMapToolSelectionHandler::selectFeaturesMoveEvent( QgsMapMouseEvent *e )
 {
+
+  if ( mSelectionMode == QgsMapToolSelectionHandler::SelectOnMouseMove )
+  {
+    mOnMouseMoveDelayTimer.reset( new QTimer( ) );
+    mOnMouseMoveDelayTimer->singleShot( 300, mOnMouseMoveDelayTimer.get(), [ = ]
+    {
+      setSelectedGeometry( QgsGeometry::fromPointXY( toMapCoordinates( e->pos() ) ), e->modifiers() );
+    } );
+
+    return;
+  }
+
   if ( e->buttons() != Qt::LeftButton )
     return;
 

diff --git a/src/app/qgsmaptoolselectionhandler.h b/src/app/qgsmaptoolselectionhandler.h
@@ -18,6 +18,7 @@
 
 #include <QObject>
 #include <QWidget>
+#include <QTimer>
 
 #include "qgsgeometry.h"
 
@@ -94,7 +95,13 @@ class QgsMapToolSelectionHandler : public QObject
       //! SelectFreehand - free hand selection
       SelectFreehand,
       //! SelectRadius - a circle selection
-      SelectRadius
+      SelectRadius,
+
+      /**
+       * SelectOnMouseMove - selection on mouse move
+       * \since QGIS 3.30
+       */
+      SelectOnMouseMove
     };
     Q_ENUM( SelectionMode )
 
@@ -200,6 +207,9 @@ class QgsMapToolSelectionHandler : public QObject
 
     //! Shows features to select polygon from existing features
     QgsIdentifyMenu *mIdentifyMenu = nullptr; // owned by canvas
+
+    //! Delay timer for continuous selection mode
+    std::unique_ptr<QTimer> mOnMouseMoveDelayTimer;
 };
 
 #endif
diff --git a/src/ui/qgsidentifyresultsbase.ui b/src/ui/qgsidentifyresultsbase.ui
@@ -325,6 +325,18 @@
     <string>Identify Features by area or single click</string>
    </property>
   </action>
+  <action name="mActionSelectFeaturesOnMouseMove">
+   <property name="icon">
+    <iconset resource="../../images/images.qrc">
+     <normaloff>:/images/themes/default/mActionIdentifyByMouseMove.svg</normaloff>:/images/themes/default/mActionIdentifyByMouseMove.svg</iconset>
+   </property>
+   <property name="text">
+    <string>Identify Feature(s) on mouse move</string>
+   </property>
+   <property name="toolTip">
+    <string>Identify Features by mouse over</string>
+   </property>
+  </action>
   <action name="mActionSelectPolygon">
    <property name="icon">
     <iconset resource="../../images/images.qrc">
@@ -407,6 +419,7 @@
  <resources>
   <include location="../../images/images.qrc"/>
   <include location="../../images/images.qrc"/>
+  <include location="../../images/images.qrc"/>
  </resources>
  <connections/>
 </ui>